Ticket #5127 task closed fixed

Opened 3 years ago

Last modified 3 years ago

Remove deprecated functions in `lore/tree.py`

Reported by: facundobatista Owned by:
Priority: normal Milestone:
Component: lore Keywords:
Cc: thijs Branch: branches/lore-tree-compare-5127
(diff, github, buildbot, log)
Author: facundobatista Launchpad Bug:

Description

This patch remove compareMarkPos and comparePosition from lore/tree.py, as they were deprecated for v9.

Attachments

remove-lore-tree-deprecated-a.patch Download (2.5 KB) - added by facundobatista 3 years ago.

Change History

Changed 3 years ago by facundobatista

1

Changed 3 years ago by thijs

  • cc thijs added
  • component changed from core to lore
  • type changed from enhancement to task
  • keywords py3k removed

2

Changed 3 years ago by thijs

  • branch set to branches/lore-tree-compare-5127
  • branch_author set to thijs

(In [32110]) Branching to 'lore-tree-compare-5127'

3

Changed 3 years ago by thijs

(In [32111]) Apply remove-lore-tree-deprecated-a.patch, add news file. refs #5127

4

Changed 3 years ago by thijs

  • branch_author changed from thijs to facundobatista

The  doc build succeeded after this change (isnt that all that matters ;). Branch up for review.

5

Changed 3 years ago by cyli

(In [32125]) Removed the unused twisted versions import as well

refs #5127

6

Changed 3 years ago by cyli

 build results look good. Merging. Thanks for applying the patch thijs!

7

Changed 3 years ago by cyli

  • status changed from new to closed
  • resolution set to fixed

(In [32126]) Merge lore-tree-compare-5127: Remove deprecated compare methods in lore

Author: facundobatista Reviewer: cyli Fixes: #5127

Removes twisted.lore.tree.compareMarkPos and twisted.lore.tree.comparePosition, both of which were deprecated in v9.0.

8

Changed 3 years ago by cyli

  • keywords review removed
Note: See TracTickets for help on using tickets.