Remove cmp usage in twisted.names.srvconnect

[facundobatista]

The attached patch removes cmp and __cmp__ usage from the following modules:

• twisted/names/dns.py
• twisted/names/srvconnect.py

All the changes are tested (had to add some tests for some changes).

[thijs]

fixup ticket description.

[thijs]

Thanks for the patch.

compareMarkPos and 'comparePosition' in [trunk/twisted/lore/tree.py] are deprecated since Twisted 9.0, so they shouldn't be updated but removed instead. I guess that needs a new ticket because every removal needs a ticket. So I suggest opening a new one for lore with a patch that removes those deprecated methods, and ignoring the lore changes in the patch on this ticket.

[exarkun]

Don't spent time on Lore maintenance. Work on the Sphinx conversion. :)

[facundobatista]

thijs: I created ticket #5127 for the removal of these methods, and attached a new patch here with the changes in names only. Thanks!

exarkun: I don't want to spend any time in Lore, but I need those cmp out of the way for Py3k :).

[facundobatista]

Changes in 'names' only

[thijs]

Replying to facundobatista:

thijs: I created ticket #5127 for the removal of these methods, and attached a new patch here with the changes in names only. Thanks!

Thanks, I'll update the ticket title and summary to reflect this update.

[thijs]

(In [32112]) Branching to 'names-cmp-5124'

[thijs]

(In [32113]) apply remove-cmp-02b.patch, add news file. refs #5124

[thijs]

(In [32114]) pyflakes and coding std fixes, refs #5124

[thijs]

The  build results show 3 failing tests. Can you make new patches against this branch?

[facundobatista]

Removed the assertLess calls.

[facundobatista]

Attached the 'c' version of the patch, where I removed the assertLess calls (that were only 2.7, sorry).

[glyph]

It appears that this patch has a glaring omission: to wit, tests for > comparison. Is there a rule about __gt__ that it automatically works if __lt__, __eq__ and __ne__ are all implemented? In any case I think more test coverage is required...

[facundobatista]

Yes, gt automatically works if lt is implemented and both are the same type (because of reflection when doing the comparison... Python doesn't find gt on one object, tries lt on the other).

However, the <= comparisons weren't working... I added code for that, and tests cases for everything.

'c' version of the patch is attached.

[facundobatista]

Bah, sorry, the version of the patch for these last improvements is the 'd' one.

[facundobatista]

Support all comparisons, with more tests

[dustin]

In twisted/names/dns.py, the fallback for le uses < instead of <=. The effect is negligible - a Query is never equal to anything else, so <= and < are equivalent, but the difference stands out in the code and looks suspicious, so it should be corrected. On that note, what is the point of self.__class__ == other.__class__ if you already know that other is not an instance of Query? Why not just return False from __eq___ in that case?

I can't see any other problems - all of the comments in the previous reviews seem to be addressed.

[thijs]

#5348 was marked as a duplicate.

[thijs]

The first part of this ticket (twisted.names.dns) was fixed with #6059.