Ticket #5116 enhancement closed fixed

Opened 3 years ago

Last modified 2 years ago

twisted.internet.iocpreactor.iocpsupport.fillinetaddr should take an address family parameter and support AF_INET6

Reported by: PenguinOfDoom Owned by:
Priority: normal Milestone:
Component: core Keywords: review
Cc: Branch: branches/iocp-connect-ipv6-5116
(diff, github, buildbot, log)
Author: pahan Launchpad Bug:

Description

iocpreactor's ConnectEx wrapper does not currently support AF_INET6 sockets and addresses

Change History

1

Changed 3 years ago by pahan

  • branch set to branches/iocp-connect-ipv6-5116
  • branch_author set to pahan

(In [31910]) Branching to 'iocp-connect-ipv6-5116'

2

Changed 2 years ago by glyph

  • owner changed from PenguinOfDoom to glyph
  • status changed from new to assigned

This is fixed in the same branch as #5085.

3

Changed 2 years ago by glyph

  • status changed from assigned to new
  • keywords review added
  • owner glyph deleted

Putting this up for review because the reviewer of #5085 definitely deserves some bonus points. (And, if they are so inclined, they may review this portion separately.)

4

Changed 2 years ago by glyph

  • status changed from new to closed
  • resolution set to fixed

(In [34020]) Merge ipv6-connectTCP-5085-2.

Author: acapnotic, glyph, chjurk, ragzilla

Reviewer: exarkun

Allow Twisted to connect to IPv6 addresses, using all currently supported reactors.

IPv6 clients are supported by passing an IPv6 address literal to connectTCP. Hostname resolution is the responsibility of the caller.

This change also significantly improves the internal maintenance documentation coverage for twisted.internet.tcp and refactors more client code to be shared between the IOCP reactor and all the UNIX reactors.

Fixes: #5085 Fixes: #5116

Note: See TracTickets for help on using tickets.