Opened 6 years ago

Closed 6 years ago

Last modified 12 months ago

#5114 enhancement closed fixed (fixed)

LoopingCall should be resetable

Reported by: Christian Kampka Owned by: therve
Priority: normal Milestone:
Component: core Keywords: patch
Cc: Thijs Triemstra Branch: branches/reset-loop-5114
branch-diff, diff-cov, branch-cov, buildbot
Author: therve

Description

It would be a good thing if the LoopingCall would be "resetable", meaning it should be easy to stop the currently scheduled call and reschedule it with the currently set interval, providing a nicer alternative to stopping the call and starting a new LoopingCall with the exact same settings. The following patch implements this.

Attachments (1)

reset_loop.patch (1.5 KB) - added by Christian Kampka 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by Christian Kampka

Attachment: reset_loop.patch added

comment:1 Changed 6 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review added

Adding missing 'review' keyword (see ReviewProcess).

comment:2 Changed 6 years ago by therve

Owner: set to therve

comment:3 Changed 6 years ago by therve

Author: therve
Branch: branches/reset-loop-5114

(In [31998]) Branching to 'reset-loop-5114'

comment:4 Changed 6 years ago by therve

Resolution: fixed
Status: newclosed

(In [32000]) Merge reset-loop-5114

Author: chris Reviewer: therve Fixes: #5114

Add a reset method to LoopingCall to be able to stop it and reschedule at once.

comment:5 Changed 12 months ago by hawkowl

Keywords: review removed

[mass edit] Removing review from closed tickets.

Note: See TracTickets for help on using tickets.