Opened 3 years ago

Closed 3 years ago

#5112 defect closed fixed (fixed)

coding-standard.xhtml describes old copyright header format

Reported by: ivank Owned by: exarkun
Priority: normal Milestone:
Component: core Keywords: documentation easy
Cc: ivank-twisted-bugs@… Branch: branches/copyright-policy-5112
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

http://twistedmatrix.com/trac/browser/trunk/doc/core/development/policy/coding-standard.xhtml?format=raw says:

# Copyright (c) 2009 Twisted Matrix Laboratories.
# See LICENSE for details.


    When you update existing files, make sure the year in the copyright
    header is up to date as well. You should add a new copyright header when
    it's completely missing in the file that is being edited.

We don't have years in the copyright headers any more.

Change History (6)

comment:1 Changed 3 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/copyright-policy-5112

(In [31925]) Branching to 'copyright-policy-5112'

comment:2 Changed 3 years ago by exarkun

  • Keywords review added

Thanks for pointing that out. Fix is in the branch.

comment:3 Changed 3 years ago by ivank

  • Cc ivank-twisted-bugs@… added
  • Keywords review removed
  1. Please fix "including the year the file was added" as well.

Otherwise, looks good.

comment:4 Changed 3 years ago by ivank

  • Owner set to exarkun

comment:5 Changed 3 years ago by exarkun

(In [31930]) Oops, remove the other year-related recommendation

refs #5112

comment:6 Changed 3 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [31931]) Merge copyright-policy-5112

Author: exarkun
Reviewer: ivank
Fixes: #5112

Remove the recommendation to include the year in copyright headers, matching
what we currently actually want to do with respect to these. See #4857.

Note: See TracTickets for help on using tickets.