Opened 6 years ago

Closed 5 years ago

#5060 defect closed fixed (fixed)

Correct python requirement in twisted/topfiles/setup.py

Reported by: Thijs Triemstra Owned by: Jean-Paul Calderone
Priority: normal Milestone:
Component: core Keywords:
Cc: Thijs Triemstra, jesstess Branch: branches/minimum-supported-2.5-5060
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description (last modified by Thijs Triemstra)

[source:trunk/twisted/topfiles/setup.py] forces Python 2.3 to be the minimum but this should be 2.4 like the check in [source:trunk/twisted/__init__.py]. Perhaps it should be centralized somewhere, available to other packages as well, like the copyright/version string?

Change History (9)

comment:1 Changed 6 years ago by Thijs Triemstra

Description: modified (diff)

comment:2 Changed 6 years ago by Thijs Triemstra

Another python2.3 reference can be found in [source:trunk/twisted/python/dist.py#L80].

comment:3 Changed 6 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/minimum-supported-2.5-5060

(In [32951]) Branching to 'minimum-supported-2.5-5060'

comment:4 Changed 6 years ago by Jean-Paul Calderone

(In [32979]) Drop some Python 2.2 support code, bump the documentation and install-ish time checks to Python 2.5

refs #5060

comment:5 Changed 6 years ago by Jean-Paul Calderone

Keywords: review added

Made some changes in the branch. Didn't try to refactor the duplication. That'd be nice, but changing this is a very infrequent event so I don't quite feel motivated enough to figure out how to do that.

Tentatively added a .removal news fragment; maybe that's how we want to express this change to users, maybe not.

comment:6 Changed 5 years ago by jesstess

Owner: set to jesstess

comment:7 Changed 5 years ago by jesstess

Cc: jesstess added
Keywords: review removed

Ticket 4962 describes when to drop support for Python 2.4, which currently says announcing it in 11.1 and dropping in the subsequent release. Reviewing in anticipation of that:

  • Your changes look good.
  • There are a lot of old references to Python 2.2., 2.3, and 2.4 that should get looked at in a couple of new tickets. I opened 5385, 5386, and 5387 to track these. There are also some comments about Linux 2.2 that could probably also go away.

comment:8 Changed 5 years ago by jesstess

Owner: changed from jesstess to Jean-Paul Calderone

comment:9 Changed 5 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [33200]) Merge minimum-supported-2.5-5060

Author: exarkun Reviewer: jesstess Fixes: #5060

Change overall version checks and install documentation to require Python 2.5, reflecting the decision to make that the minimum required version of Python from the next release onward.

Note: See TracTickets for help on using tickets.