Ticket #5060 defect closed fixed

Opened 2 years ago

Last modified 18 months ago

Correct python requirement in twisted/topfiles/setup.py

Reported by: thijs Owned by: exarkun
Priority: normal Milestone:
Component: core Keywords:
Cc: thijs, jesstess Branch: branches/minimum-supported-2.5-5060
Author: exarkun Launchpad Bug:

Description (last modified by thijs) (diff)

trunk/twisted/topfiles/setup.py forces Python 2.3 to be the minimum but this should be 2.4 like the check in trunk/twisted/__init__.py. Perhaps it should be centralized somewhere, available to other packages as well, like the copyright/version string?

Change History

1

Changed 2 years ago by thijs

  • description modified (diff)

2

Changed 2 years ago by thijs

Another python2.3 reference can be found in trunk/twisted/python/dist.py#L80.

3

Changed 19 months ago by exarkun

  • branch set to branches/minimum-supported-2.5-5060
  • branch_author set to exarkun

(In [32951]) Branching to 'minimum-supported-2.5-5060'

4

Changed 19 months ago by exarkun

(In [32979]) Drop some Python 2.2 support code, bump the documentation and install-ish time checks to Python 2.5

refs #5060

5

Changed 19 months ago by exarkun

  • keywords review added

Made some changes in the branch. Didn't try to refactor the duplication. That'd be nice, but changing this is a very infrequent event so I don't quite feel motivated enough to figure out how to do that.

Tentatively added a .removal news fragment; maybe that's how we want to express this change to users, maybe not.

6

Changed 19 months ago by jesstess

  • owner set to jesstess

7

Changed 19 months ago by jesstess

  • keywords review removed
  • cc jesstess added

Ticket 4962 describes when to drop support for Python 2.4, which currently says announcing it in 11.1 and dropping in the subsequent release. Reviewing in anticipation of that:

  • Your changes look good.
  • There are a lot of old references to Python 2.2., 2.3, and 2.4 that should get looked at in a couple of new tickets. I opened 5385, 5386, and 5387 to track these. There are also some comments about Linux 2.2 that could probably also go away.

8

Changed 19 months ago by jesstess

  • owner changed from jesstess to exarkun

9

Changed 18 months ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [33200]) Merge minimum-supported-2.5-5060

Author: exarkun Reviewer: jesstess Fixes: #5060

Change overall version checks and install documentation to require Python 2.5, reflecting the decision to make that the minimum required version of Python from the next release onward.

Note: See TracTickets for help on using tickets.