Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5046 task closed fixed (fixed)

Remove dead code in `twisted/protocols/ftp.py` relating to OTP authentication

Reported by: Jean-Paul Calderone Owned by:
Priority: low Milestone:
Component: ftp Keywords:
Cc: itamarst, Thijs Triemstra Branch:
Author:

Description

Long ago, it seems we tried to implement an OTP scheme for FTP authentication. This has mostly been removed, but a piece of it remains, the 'userotp' entry in the RESPONSE dict.

Change History (6)

comment:1 Changed 6 years ago by DefaultCC Plugin

Cc: itamarst added

comment:2 Changed 6 years ago by Thijs Triemstra

Cc: Thijs Triemstra added

comment:3 Changed 6 years ago by Adi Roiban

Keywords: review added

I have created a branch that tries to fix this ticket.

The branch is here: https://code.launchpad.net/~adiroiban/twisted/twisted-5046

The LP MP is here: https://code.launchpad.net/~adiroiban/twisted/twisted-5046/+merge/74920

Cheers, Adi

comment:4 Changed 6 years ago by Itamar Turner-Trauring

Thanks for the patch! Note that this would be even easier for me to apply if it included a news file (in this case an empty 5046.misc).

comment:5 Changed 6 years ago by itamarst

Resolution: fixed
Status: newclosed

(In [32545]) Apply patch for 5046.

Author: adiroiban Fixes: #5046

Remove unused reference to OTP.

comment:6 Changed 6 years ago by Itamar Turner-Trauring

Keywords: review removed
Note: See TracTickets for help on using tickets.