Opened 7 years ago

Closed 6 years ago

#5042 defect closed fixed (fixed)

distutils packager/installer includes admin tools not meant to be included

Reported by: Jean-Paul Calderone Owned by: Thijs Triemstra
Priority: normal Milestone: Twisted-11.1
Component: release management Keywords:
Cc: radix, Thijs Triemstra, jesstess Branch:
Author:

Description

bin/admin/ includes release management tools. These are not intended to be released. However, they're found by setup.py and included in the release.

Attachments (1)

exclude-admin-5042.patch (861 bytes) - added by Thijs Triemstra 7 years ago.
only include listed twisted projects

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by DefaultCC Plugin

Cc: radix added

comment:2 Changed 7 years ago by Jean-Paul Calderone

Milestone: Twisted-11.1
Type: enhancementdefect

comment:3 Changed 7 years ago by Jean-Paul Calderone

admin is identified as a subproject by the top-level setup.py, instead it should be skipped I suppose. There's a list of valid subprojects in twisted.python.dist.

comment:4 Changed 7 years ago by Jean-Paul Calderone

Owner: Jean-Paul Calderone deleted

comment:5 Changed 7 years ago by Thijs Triemstra

Cc: Thijs Triemstra added

Changed 7 years ago by Thijs Triemstra

Attachment: exclude-admin-5042.patch added

only include listed twisted projects

comment:6 Changed 7 years ago by Thijs Triemstra

Keywords: review added

Attached patch only includes sub-projects in bin that are defined in twisted.python.dist.twisted_subprojects.

comment:7 Changed 6 years ago by jesstess

Cc: jesstess added
Keywords: review removed
Owner: set to Thijs Triemstra

Thanks for working on this, thijs. I didn't cut a release to do an end-to-end test of this, but the changes look good, so if you're happy with how much it's been tested please merge.

comment:8 Changed 6 years ago by Thijs Triemstra

Resolution: fixed
Status: newclosed

(In [32049]) Apply exclude-admin-5042.patch: setup.py now only includes registered Twisted sub-projects, and ignores other directories, like bin/admin, that contain various tools that should not be included in a release.

Author: thijs Reviewer: jesstess Fixes: #5042

Note: See TracTickets for help on using tickets.