Ticket #5036 task closed fixed

Opened 2 years ago

Last modified 14 months ago

Remove deprecated t.p.text.docstringLStrip

Reported by: thijs Owned by: ClearliteX
Priority: low Milestone:
Component: core Keywords:
Cc: thijs, ekskiba@… Branch:
Author: Launchpad Bug:

Description

This was deprecated in twisted 10.2 (#4328) and can be removed.

Attachments

5036.diff Download (2.4 KB) - added by ClearliteX 14 months ago.

Change History

Changed 14 months ago by ClearliteX

1

Changed 14 months ago by ClearliteX

  • keywords review added
  • cc ekskiba@… added

Removed deprecated code and its test.

2

Changed 14 months ago by arsenerei

  • keywords review removed
  • owner set to ClearliteX

Looks good to me.

3

Changed 14 months ago by cyli

Thanks for working on this, ClearliteX! And thank you for reviewing this, arsenerei!

I am merging it now. ( buildbot results)

@ClearliteX - Just two minor nitpicks, for future patches:

  • If imports are no longer used after code is removed, the imports should probably be removed. In this case in text.py, that would be this line: 
    from twisted.python import deprecate, versions
  • A news file should be included for each ticket.

Once again, thank you for working on this!

4

Changed 14 months ago by cyli

  • status changed from new to closed
  • resolution set to fixed

Trac commit hooks seems to be broken, so I am just going to close this ticket manually.

Changes have been merged in 33703 (this link seems to be broken for now - possibly part of the same trac issues). This should have been the commit message: 

Merge remove-docstringLStrip-5036: Remove deprecated t.p.text.docstringLStrip

Author: ClearliteX
Reviewer: arsenerei
Fixes: #5036

Apply patch from ClearliteX to remove deprecated twisted.python.text.docstringLS
trip and related tests
Note: See TracTickets for help on using tickets.