Opened 3 years ago

Closed 3 years ago

#5036 task closed fixed (fixed)

Remove deprecated t.p.text.docstringLStrip

Reported by: thijs Owned by: ClearliteX
Priority: low Milestone:
Component: core Keywords:
Cc: thijs, ekskiba@… Branch:
Author: Launchpad Bug:

Description

This was deprecated in twisted 10.2 (#4328) and can be removed.

Attachments (1)

5036.diff (2.4 KB) - added by ClearliteX 3 years ago.

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by ClearliteX

comment:1 Changed 3 years ago by ClearliteX

  • Cc ekskiba@… added
  • Keywords review added

Removed deprecated code and its test.

comment:2 Changed 3 years ago by arsenerei

  • Keywords review removed
  • Owner set to ClearliteX

Looks good to me.

comment:3 Changed 3 years ago by cyli

Thanks for working on this, ClearliteX! And thank you for reviewing this, arsenerei!

I am merging it now. (buildbot results)

@ClearliteX - Just two minor nitpicks, for future patches:

  • If imports are no longer used after code is removed, the imports should probably be removed. In this case in text.py, that would be this line:
    from twisted.python import deprecate, versions
    

Once again, thank you for working on this!

comment:4 Changed 3 years ago by cyli

  • Resolution set to fixed
  • Status changed from new to closed

Trac commit hooks seems to be broken, so I am just going to close this ticket manually.

Changes have been merged in 33703 (this link seems to be broken for now - possibly part of the same trac issues). This should have been the commit message:

Merge remove-docstringLStrip-5036: Remove deprecated t.p.text.docstringLStrip

Author: ClearliteX
Reviewer: arsenerei
Fixes: #5036

Apply patch from ClearliteX to remove deprecated twisted.python.text.docstringLS
trip and related tests
Note: See TracTickets for help on using tickets.