twisted.internet.test.reactormixins makes some mistakes about which reactors it tries to test
|Reported by:||exarkun||Owned by:||exarkun|
(diff, github, buildbot, log)
The idea behind ReactorBuilder._reactors is that it's just a list of all the reactors we've got, and if the reactor can be imported and installed, it's supported on the current platform and should be tested.
This is a little too simple when it comes to the glib2 and gtk2 reactors though. Glib2Reactor and Gtk2Reactor can both be used on Windows, but actually PortableGtk2Reactor is what you get in real life if you ask for gtk2 on Windows. And Glib2Reactor really just shouldn't be used, I guess (although maybe that's a question to settle on another day).
A less important problem is that trying the full list all the time generates a mountain of skips at the end of every test run, because every platform has some reactors it is just never going to be able to run.
This list should be computed with a little more thought to avoid these problems.
This came up as I was trying to get some new tests working in the #4854 branch and noticed that Gtk2Reactor was being used on Windows.
Change History (8)
comment:5 Changed 3 years ago by jesstess
- Cc jessica.mckellar@… added
- Keywords review removed
- Owner changed from jesstess to exarkun