Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#4966 defect closed fixed (fixed)

NOT_DONE_YET is missing from __all__ in twisted.web.server

Reported by: lvh Owned by: teratorn
Priority: normal Milestone:
Component: web Keywords: easy
Cc: jknight, thijs Branch: branches/not-done-yet-4966
(diff, github, buildbot, log)
Author: teratorn Launchpad Bug:

Description

This causes Pydoctor not to document it, which causes broken links in the documentation. Similar to #3904, found in #4951.

Attachments (1)

twisted4966.patch (527 bytes) - added by necaris 3 years ago.
Patch to add all to twisted/web/server.py

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by DefaultCC Plugin

  • Cc jknight added

comment:2 Changed 4 years ago by lvh

  • Type changed from enhancement to defect

comment:3 Changed 4 years ago by tenth

It doesn't seem like PyDoctor wants to document NOT_DONE_YET, even if it is included in all, but that may be related to this bug wherein PyDoctor ignores constants?

comment:4 Changed 4 years ago by thijs

  • Cc thijs added

Changed 3 years ago by necaris

Patch to add all to twisted/web/server.py

comment:5 Changed 3 years ago by necaris

  • Keywords review added

comment:6 Changed 3 years ago by teratorn

  • Owner set to teratorn

comment:7 Changed 3 years ago by teratorn

  • Author set to teratorn
  • Branch set to branches/not-done-yet-4966

(In [33760]) Branching to 'not-done-yet-4966'

comment:8 Changed 3 years ago by teratorn

  • Resolution set to fixed
  • Status changed from new to closed

(In [33767]) Merge not-done-yet-4966: provide an all in t.web.server.py to help out doc building

Author: necaris
Reviewer: teratorn
Fixes: #4966

comment:9 Changed 3 years ago by teratorn

  • Keywords review removed

Forgot to remove review keyword.

Note: See TracTickets for help on using tickets.