Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#4966 defect closed fixed (fixed)

NOT_DONE_YET is missing from __all__ in twisted.web.server

Reported by: lvh Owned by: teratorn
Priority: normal Milestone:
Component: web Keywords: easy
Cc: jknight, Thijs Triemstra Branch: branches/not-done-yet-4966
branch-diff, diff-cov, branch-cov, buildbot
Author: teratorn

Description

This causes Pydoctor not to document it, which causes broken links in the documentation. Similar to #3904, found in #4951.

Attachments (1)

twisted4966.patch (527 bytes) - added by Rami C 5 years ago.
Patch to add all to twisted/web/server.py

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by DefaultCC Plugin

Cc: jknight added

comment:2 Changed 6 years ago by lvh

Type: enhancementdefect

comment:3 Changed 6 years ago by David Sturgis

It doesn't seem like PyDoctor wants to document NOT_DONE_YET, even if it is included in all, but that may be related to this bug wherein PyDoctor ignores constants?

comment:4 Changed 6 years ago by Thijs Triemstra

Cc: Thijs Triemstra added

Changed 5 years ago by Rami C

Attachment: twisted4966.patch added

Patch to add all to twisted/web/server.py

comment:5 Changed 5 years ago by Rami C

Keywords: review added

comment:6 Changed 5 years ago by teratorn

Owner: set to teratorn

comment:7 Changed 5 years ago by teratorn

Author: teratorn
Branch: branches/not-done-yet-4966

(In [33760]) Branching to 'not-done-yet-4966'

comment:8 Changed 5 years ago by teratorn

Resolution: fixed
Status: newclosed

(In [33767]) Merge not-done-yet-4966: provide an all in t.web.server.py to help out doc building

Author: necaris Reviewer: teratorn Fixes: #4966

comment:9 Changed 5 years ago by teratorn

Keywords: review removed

Forgot to remove review keyword.

Note: See TracTickets for help on using tickets.