Ticket #4966 defect closed fixed

Opened 3 years ago

Last modified 2 years ago

NOT_DONE_YET is missing from __all__ in twisted.web.server

Reported by: lvh Owned by: teratorn
Priority: normal Milestone:
Component: web Keywords: easy
Cc: jknight, thijs Branch: branches/not-done-yet-4966
(diff, github, buildbot, log)
Author: teratorn Launchpad Bug:

Description

This causes Pydoctor not to document it, which causes broken links in the documentation. Similar to #3904, found in #4951.

Attachments

twisted4966.patch Download (0.5 KB) - added by necaris 2 years ago.
Patch to add all to twisted/web/server.py

Change History

1

Changed 3 years ago by DefaultCC Plugin

  • cc jknight added

2

Changed 3 years ago by lvh

  • type changed from enhancement to defect

3

Changed 3 years ago by tenth

It doesn't seem like PyDoctor wants to document NOT_DONE_YET, even if it is included in all, but that may be related to  this bug wherein PyDoctor ignores constants?

4

Changed 3 years ago by thijs

  • cc thijs added

Changed 2 years ago by necaris

Patch to add all to twisted/web/server.py

5

Changed 2 years ago by necaris

  • keywords review added

6

Changed 2 years ago by teratorn

  • owner set to teratorn

7

Changed 2 years ago by teratorn

  • branch set to branches/not-done-yet-4966
  • branch_author set to teratorn

(In [33760]) Branching to 'not-done-yet-4966'

8

Changed 2 years ago by teratorn

  • status changed from new to closed
  • resolution set to fixed

(In [33767]) Merge not-done-yet-4966: provide an all in t.web.server.py to help out doc building

Author: necaris Reviewer: teratorn Fixes: #4966

9

Changed 2 years ago by teratorn

  • keywords review removed

Forgot to remove review keyword.

Note: See TracTickets for help on using tickets.