Opened 3 years ago

Closed 3 years ago

#4946 enhancement closed fixed (fixed)

Deprecate allYourBase and accumulateBases

Reported by: lvh Owned by: lvh
Priority: normal Milestone:
Component: core Keywords: easy
Cc: Branch: branches/deprecate-reflect-stuff-4946
(diff, github, buildbot, log)
Author: lvh Launchpad Bug:

Description

For more details see #4928 -- we've removed the use cases for this except in some code which is going to be deprecated so we should probably deprecate this in favor of fancy inspect module functions.

Attachments (1)

4946.patch (2.1 KB) - added by aruse 3 years ago.
Deprecation of allYourBase and accumulateBases

Download all attachments as: .zip

Change History (7)

comment:1 Changed 3 years ago by aruse

  • Owner set to aruse
  • Status changed from new to assigned

Changed 3 years ago by aruse

Deprecation of allYourBase and accumulateBases

comment:2 Changed 3 years ago by aruse

  • Keywords review added
  • Owner aruse deleted
  • Status changed from assigned to new

comment:3 Changed 3 years ago by lvh

  • Keywords changed from easy, review to easy review
  • Owner set to lvh
  • Status changed from new to assigned

comment:4 Changed 3 years ago by lvh

  • Author set to lvh
  • Branch set to branches/deprecate-reflect-stuff-4946

(In [31036]) Branching to 'deprecate-reflect-stuff-4946'

comment:5 Changed 3 years ago by lvh

  • Keywords review removed

Thanks for your patch! This is great, but blocking on #4928 since until that gets merged Twisted itself still uses allYourBase so it fires its own DeprecationWarning. As soon as that's fixed we should merge branches/deprecate-reflect-stuff-4946 into trunk.

comment:6 Changed 3 years ago by lvh

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [31056]) allYourBase and accumulateBases are now deprecated in favor of inspect.getmro

Author: aruse
Reviewer: lvh
Fixes: #4946

Note: See TracTickets for help on using tickets.