Opened 6 years ago

Closed 6 years ago

#4944 enhancement closed fixed (fixed)

Mysterious semicolons in docs `core/howto/quotes`

Reported by: khorn Owned by: Thijs Triemstra
Priority: normal Milestone:
Component: core Keywords: documentation
Cc: Thijs Triemstra Branch: branches/remove-semicolons-from-quotes-docs-4944
branch-diff, diff-cov, branch-cov, buildbot
Author: thijs

Description

From #4865, tenth says:

I noticed that there are mysterious semicolons after the second and third Python code blocks... They are present in the original Lore version of the docs, but they look like typos to me. Unless they have some purpose, we should probably remove those as well?

These probably should be removed, but as they are not really a problem for the conversion to Sphinx, I'm creating a new ticket.

Attachments (1)

quotes-semicolon.patch (1.0 KB) - added by Thijs Triemstra 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by Thijs Triemstra

Owner: set to Thijs Triemstra
Status: newassigned

Changed 6 years ago by Thijs Triemstra

Attachment: quotes-semicolon.patch added

comment:2 Changed 6 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review added
Owner: Thijs Triemstra deleted
Status: assignednew

comment:3 Changed 6 years ago by Ying Li

Author: cyli
Branch: branches/remove-semicolons-from-quotes-docs-4944

(In [32215]) Branching to 'remove-semicolons-from-quotes-docs-4944'

comment:4 Changed 6 years ago by Ying Li

(In [32216]) Apply quotes-semicolon.patch

refs #4944

comment:5 Changed 6 years ago by Ying Li

Keywords: review removed
Owner: set to Thijs Triemstra

Thanks for working on this thijs! doc buildbot looks fine. Please merge.

comment:6 Changed 6 years ago by Thijs Triemstra

Author: cylithijs
Status: newassigned

Thanks for the review.

comment:7 Changed 6 years ago by Thijs Triemstra

Resolution: fixed
Status: assignedclosed

(In [32227]) Merge remove-semicolons-from-quotes-docs-4944: Remove semicolons from the TwistedQuotes directory structure overview.

Author: thijs Reviewer: cyli Fixes: #4944

Note: See TracTickets for help on using tickets.