FTP server lacks tests for RNTO and RNFR.
|Reported by:||Adi Roiban||Owned by:||spiv|
|Cc:||itamarst, Adi Roiban, Thijs Triemstra||Branch:||
branch-diff, diff-cov, branch-cov, buildbot
Description (last modified by )
calling RNTO while being authenticated, without calling RNFR will generate an unhandled exceptions since self._fromName is only defined in RNFR.
Here is a patch that identifies the problem:
Please let me know if you agree with with fix and I could provide a full patch together with the required tests.
=== modified file 'TwistedCore-10.2.0/twisted/protocols/ftp.py'
752 752 return BAD_CMD_SEQ, "PASS required after USER" 753 753 754 754 elif self.state == self.AUTHED: 755 756 755 757 method = getattr(self, "ftp_" + cmd, None) 756 758 if method is not None: 757 759 return method(*params)
Change History (18)
comment:5 Changed 5 years ago by
|Cc:||Thijs Triemstra added|
|Owner:||set to Adi Roiban|
comment:10 Changed 5 years ago by
|Summary:||RNTO without prior calling RNFR should send a bad command sequence response → FTP server lacks tests for RNTO and RNFR.|