Opened 7 years ago

Closed 7 years ago

#4911 defect closed fixed (fixed)

twisted.web.http docstring indicates chunked transfer is not supported

Reported by: Andy Meyer Owned by: Jean-Paul Calderone
Priority: normal Milestone:
Component: web Keywords:
Cc: jknight Branch:
Author:

Description

From the module docstring list of future plans:

" - Accept chunked data from clients in server."

whereas later in the file there's a bunch of support for it, and it appears to work fine.

Attachments (1)

http-docstring.patch (781 bytes) - added by Jean-Paul Calderone 7 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by DefaultCC Plugin

Cc: jknight added

Changed 7 years ago by Jean-Paul Calderone

Attachment: http-docstring.patch added

comment:2 Changed 7 years ago by Jean-Paul Calderone

Keywords: review added

comment:3 Changed 7 years ago by Itamar Turner-Trauring

Keywords: review removed
Owner: set to Jean-Paul Calderone
  1. Needs .misc news file.
  1. The docstring isn't quite a accurate - some of the code is used by _newclient, e.g. the chunked encoding parser. So maybe mention "Plus some utility classes used by the HTTP client" (PotentialDataLoss is the only public thing a client *user* would end up knowing about, I think.)
  1. It'd be nice if my name was removed as maintainer. Not essential though.

Other than that, looks good. Feel free to commit with #1, and #2/#3 if you feel like it.

comment:4 Changed 7 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [30897]) Update the twisted.web.http module docstring to more accurately reflect that module's current state

Author: exarkun Reviewer: itamar Fixes: #4911

Note: See TracTickets for help on using tickets.