Ticket #4911 defect closed fixed

Opened 2 years ago

Last modified 2 years ago

twisted.web.http docstring indicates chunked transfer is not supported

Reported by: andy Owned by: exarkun
Priority: normal Milestone:
Component: web Keywords:
Cc: jknight Branch:
Author: Launchpad Bug:

Description

From the module docstring list of future plans:

" - Accept chunked data from clients in server."

whereas later in the file there's a bunch of support for it, and it appears to work fine.

Attachments

http-docstring.patch Download (0.8 KB) - added by exarkun 2 years ago.

Change History

1

Changed 2 years ago by DefaultCC Plugin

  • cc jknight added

Changed 2 years ago by exarkun

2

Changed 2 years ago by exarkun

  • keywords review added

3

Changed 2 years ago by itamar

  • owner set to exarkun
  • keywords review removed

1. Needs .misc news file.

2. The docstring isn't quite a accurate - some of the code is used by _newclient, e.g. the chunked encoding parser. So maybe mention "Plus some utility classes used by the HTTP client" (PotentialDataLoss is the only public thing a client *user* would end up knowing about, I think.)

3. It'd be nice if my name was removed as maintainer. Not essential though.

Other than that, looks good. Feel free to commit with #1, and #2/#3 if you feel like it.

4

Changed 2 years ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [30897]) Update the twisted.web.http module docstring to more accurately reflect that module's current state

Author: exarkun Reviewer: itamar Fixes: #4911

Note: See TracTickets for help on using tickets.