Ticket #4872 enhancement closed fixed

Opened 2 years ago

Last modified 2 years ago

Improve lore2sphinx buildbot results for `projects/core/howto/cred.xhtml`

Reported by: exarkun Owned by:
Priority: normal Milestone: Lore to Sphinx
Component: core Keywords: documentation
Cc: Branch: branches/cred-sphinx-4872
Author: screwtape, jdb Launchpad Bug:

Description

like #4566, except for the cred howto

Change History

1

Changed 2 years ago by exarkun

  • branch set to branches/cred-sphinx-4872
  • branch_author set to exarkun

(In [30676]) Branching to 'cred-sphinx-4872'

2

Changed 2 years ago by exarkun

  • keywords review added
  • branch_author changed from exarkun to screwtape, jdb

3

Changed 2 years ago by exarkun

(In [30677]) Merge the cred parts of the impossibly huge #4568 branch

refs #4568 refs #4872

4

Changed 2 years ago by <automation>

5

Changed 2 years ago by moshez

  • keywords review removed
  • owner set to exarkun

There is a move of newline from before "is" (in "the mind is") to after it, and a couple of trailing spaces. Why is that?

6

Changed 2 years ago by exarkun

  • owner exarkun deleted
  • keywords review added

To fix the generated ReST markup.

7

Changed 2 years ago by khorn

  • milestone set to Lore to Sphinx

8

Changed 2 years ago by lvh

  • keywords review removed

9

Changed 2 years ago by lvh

There are three changes in this diff. The first two produce  broken output, the last one is fine.

  1. put "is" on the next line, problem is missing space, resulting in None not being monospace (generated reST: Typically you only pass in one interface, and the mind is``None``)
  2. putting *interfaces in <code> tags, converter doesn't add backticks, Sphinx somehow manages to interpret the result as a link (???) (generated reST: which was one of the interfaces passed in the *interfaces tuple)
  3. something about myapp_plugins.py, which works fine

This is impossible to fix in the conversion script, so this Sphinx file requires manual intervention. Neither change is particularly hard: one space and two pairs of backticks.

10

Changed 2 years ago by lvh

We're merging this anyway. See #4940 for actually fixing the problems in the last comment.

11

Changed 2 years ago by lvh

  • status changed from new to closed
  • resolution set to fixed

(In [31003]) Merge cred.xhtml changes from cred-sphinx-4872.

Author: screwtape, jdb Reviewer: lvh Fixes: #4872 "Makes Sphinx looks gooder." -- JP

There are problems left, for which there is #4940.

Note: See TracTickets for help on using tickets.