Opened 4 years ago

Closed 4 years ago

#4872 enhancement closed fixed (fixed)

Improve lore2sphinx buildbot results for `projects/core/howto/cred.xhtml`

Reported by: exarkun Owned by:
Priority: normal Milestone: Lore to Sphinx
Component: core Keywords: documentation
Cc: Branch: branches/cred-sphinx-4872
(diff, github, buildbot, log)
Author: screwtape, jdb Launchpad Bug:

Description

like #4566, except for the cred howto

Change History (11)

comment:1 Changed 4 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/cred-sphinx-4872

(In [30676]) Branching to 'cred-sphinx-4872'

comment:2 Changed 4 years ago by exarkun

  • Author changed from exarkun to screwtape, jdb
  • Keywords review added

comment:3 Changed 4 years ago by exarkun

(In [30677]) Merge the cred parts of the impossibly huge #4568 branch

refs #4568
refs #4872

comment:4 Changed 4 years ago by <automation>

comment:5 Changed 4 years ago by moshez

  • Keywords review removed
  • Owner set to exarkun

There is a move of newline from before "is" (in "the mind is") to after it, and a couple of trailing spaces. Why is that?

comment:6 Changed 4 years ago by exarkun

  • Keywords review added
  • Owner exarkun deleted

To fix the generated ReST markup.

comment:7 Changed 4 years ago by khorn

  • Milestone set to Lore to Sphinx

comment:8 Changed 4 years ago by lvh

  • Keywords review removed

comment:9 Changed 4 years ago by lvh

There are three changes in this diff. The first two produce broken output, the last one is fine.

  1. put "is" on the next line, problem is missing space, resulting in None not being monospace (generated reST: Typically you only pass in one interface, and the mind is``None``)
  2. putting *interfaces in <code> tags, converter doesn't add backticks, Sphinx somehow manages to interpret the result as a link (???) (generated reST: which was one of the interfaces passed in the *interfaces tuple)
  3. something about myapp_plugins.py, which works fine

This is impossible to fix in the conversion script, so this Sphinx file requires manual intervention. Neither change is particularly hard: one space and two pairs of backticks.

comment:10 Changed 4 years ago by lvh

We're merging this anyway. See #4940 for actually fixing the problems in the last comment.

comment:11 Changed 4 years ago by lvh

  • Resolution set to fixed
  • Status changed from new to closed

(In [31003]) Merge cred.xhtml changes from cred-sphinx-4872.

Author: screwtape, jdb
Reviewer: lvh
Fixes: #4872

"Makes Sphinx looks gooder." -- JP

There are problems left, for which there is #4940.

Note: See TracTickets for help on using tickets.