Opened 4 years ago

Closed 4 years ago

#4867 enhancement closed fixed (fixed)

Improve lore2sphinx buildbot results for `projects/core/howto/components.xhtml`

Reported by: exarkun Owned by: lvh
Priority: normal Milestone: Lore to Sphinx
Component: core Keywords: documentation
Cc: Branch: branches/components-sphinx-4867
(diff, github, buildbot, log)
Author: screwtape, jdb Launchpad Bug:

Description (last modified by exarkun)

like #4566, except for the components document

Change History (9)

comment:1 Changed 4 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/components-sphinx-4867

(In [30666]) Branching to 'components-sphinx-4867'

comment:2 Changed 4 years ago by exarkun

(In [30667]) Merge the components parts of the impossibly huge #4568 branch

refs #4568
refs #4867

comment:3 Changed 4 years ago by exarkun

  • Author changed from exarkun to screwtape, jdb
  • Keywords review added

comment:4 Changed 4 years ago by exarkun

  • Description modified (diff)

comment:5 Changed 4 years ago by <automation>

comment:6 Changed 4 years ago by tenth

  • Keywords review removed
  • Owner set to Screwtape

There are a lot of changes here due to the change from 110V to 120V and "Foreign" to "UK", but everything seems to be in order.

The only inconsistency I noticed was that the doc string on the IAmericanSocket Interface's voltage() method is on the same line as the first set of triple quotes, unlike the other comments (which have been modified to have the triple quotes and text on separate lines):

class IAmericanSocket(Interface):
    def voltage():
      """Return the voltage produced by this socket object, as an integer.
      """

comment:7 Changed 4 years ago by khorn

  • Milestone set to Lore to Sphinx

comment:8 Changed 4 years ago by khorn

  • Owner changed from Screwtape to lvh

Review feedback isn't really part of the conversion process, if it's still an issue, please create a new ticket.

Other than that, this one can be merged.

comment:9 Changed 4 years ago by lvh

  • Resolution set to fixed
  • Status changed from new to closed

(In [31059]) Better lore2sphinx output for components.xhtml

Author: khorn, Screwtape, jdb
Reviewer: tenth, lvh
Fixes: #4867

"Make Sphinx look gooder" -- JP

Note: See TracTickets for help on using tickets.