Opened 3 years ago

Closed 3 years ago

#4865 enhancement closed fixed (fixed)

Improve lore2sphinx buildbot results for `projects/core/howto/quotes.xhtml`

Reported by: exarkun Owned by: lvh
Priority: normal Milestone: Lore to Sphinx
Component: core Keywords: documentation
Cc: Branch: branches/quotes-sphinx-4865
(diff, github, buildbot, log)
Author: screwtape, jdb Launchpad Bug:

Description

like #4566, except for the quotes howto

Change History (8)

comment:1 Changed 3 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/quotes-sphinx-4865

(In [30662]) Branching to 'quotes-sphinx-4865'

comment:2 Changed 3 years ago by exarkun

(In [30663]) Merge the quotes parts of the impossibly huge #4568 branch

refs #4865
refs #4568

comment:3 Changed 3 years ago by exarkun

  • Author changed from exarkun to screwtape, jdb
  • Keywords review added

comment:4 Changed 3 years ago by tenth

  • Keywords review removed
  • Owner set to Screwtape

The submitted change, which allows the "<code>/mystuff/TwistedQuotes</code>" tag to render correctly, is great.

But on viewing the rendered page, I noticed that there are mysterious semicolons after the second and third Python code blocks... They are present in the original Lore version of the docs, but they look like typos to me. Unless they have some purpose, we should probably remove those as well?

comment:5 Changed 3 years ago by khorn

  • Milestone set to Lore to Sphinx

comment:6 Changed 3 years ago by khorn

Since the Mysterious Semicolons are not really a conversion issue, opened a new ticket: #4944

If there are no other issues, this one can be merged.

comment:7 Changed 3 years ago by khorn

  • Owner changed from Screwtape to lvh

comment:8 Changed 3 years ago by lvh

  • Resolution set to fixed
  • Status changed from new to closed

(In [31060]) Better lore2sphinx output for quotes.xhtml

Author: khorn, Screwtape, jdb
Reviewer: tenth, lvh
Fixes: #4865

"Make Sphinx look gooder" -- JP

Note: See TracTickets for help on using tickets.