Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#4857 task closed fixed (fixed)

Remove dates from the per-file copyright header

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/consolidate-copyright-dates-4857
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

Currently we include this header at the top of every file in Twisted:

# Copyright (c) 2001-2010 Twisted Matrix Laboratories.
# See LICENSE for details.

with only the dates varying, depending (sometimes) on when the file was introduced and when it was last modified.

The primary outcome of this is that most reviews start with the comment:

  1. Please update the dates in the copyright header in modified files

This is strictly a waste of time for developers and reviewers.

The copyright header on all files should be changed to:

# Copyright (c) Twisted Matrix Laboratories.
# See LICENSE for details.

We should maintain a date only in the LICENSE file, and update it only at release times.

Various wiki and developer howtos should be updated to remove mentions of copyright date updates, as well.

Attachments (1)

rewrite-copyright-header.py (875 bytes) - added by Jean-Paul Calderone 7 years ago.
tool which did all of the header rewriting

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/consolidate-copyright-dates-4857

(In [30713]) Branching to 'consolidate-copyright-dates-4857'

comment:2 Changed 7 years ago by Jean-Paul Calderone

(In [30714]) Change the copyright headers with the rewrite-copyright-header.py script

refs #4857

Changed 7 years ago by Jean-Paul Calderone

Attachment: rewrite-copyright-header.py added

tool which did all of the header rewriting

comment:3 Changed 7 years ago by Jean-Paul Calderone

Keywords: review added

The branch has rewritten headers. All changes were made by the tool attached to the ticket.

comment:4 Changed 7 years ago by Glyph

Keywords: review removed
Owner: set to Jean-Paul Calderone

Yes. Please. Let's land this and centralize all the copyright brouhaha. If anyone cares about dates of individual files, version control will always be there to tell them.

comment:5 Changed 7 years ago by <automation>

Owner: Jean-Paul Calderone deleted

comment:6 Changed 7 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [30752]) Rewrite the copyright headers to exclude date information.

Author: exarkun Reviewer: glyph Fixes: #4857

To avoid the need to perpetually update copyright dates in each file in Twisted, remove the dates from most files and just leave them in the LICENSE file.

As a side effect, some files also have had a trailing newline added where it was missing before.

comment:7 Changed 6 years ago by Jean-Paul Calderone

(In [31931]) Merge copyright-policy-5112

Author: exarkun Reviewer: ivank Fixes: #5112

Remove the recommendation to include the year in copyright headers, matching what we currently actually want to do with respect to these. See #4857.

Note: See TracTickets for help on using tickets.