Opened 6 years ago

Closed 6 years ago

#4821 enhancement closed fixed (fixed)

Remove web2 from trunk

Reported by: Itamar Turner-Trauring Owned by: Jean-Paul Calderone
Priority: normal Milestone:
Component: web2 Keywords:
Cc: jesstess Branch: branches/remove-web2-4821-3
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

Web2 isn't being maintained any more, and confuses people, so we should probably remove it from the repository. To make it easy to find the code if we want to reuse parts of it (as we did for http headers), a tag of trunk from right before the deletion may be helpful.

References to web2 will also probably need to be removed from the packaging code.

Change History (16)

comment:1 Changed 6 years ago by Jean-Paul Calderone

I suppose if we do this, we can also close all of the other open web2 tickets (or redirect them against web, as appropriate).

Anyone want to speak up against doing this? Otherwise I think we should, and sooner rather than later.

The one objection I've heard so far is that removing it will make it hard to get the code. I think we can address this by doing a tag before the delete.

comment:2 Changed 6 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/remove-web2-4821

(In [30703]) Branching to 'remove-web2-4821'

comment:3 in reply to:  1 Changed 6 years ago by Thijs Triemstra

Replying to exarkun:

Anyone want to speak up against doing this? Otherwise I think we should, and sooner rather than later.

Closed #3870.

comment:4 Changed 6 years ago by <automation>

Owner: David Reid deleted

comment:5 Changed 6 years ago by Jean-Paul Calderone

Branch: branches/remove-web2-4821branches/remove-web2-4821-2

(In [30872]) Branching to 'remove-web2-4821-2'

comment:6 Changed 6 years ago by Jean-Paul Calderone

Keywords: review added

Okay, I removed it. There was a dependency on web2 in vfs, so I deleted some vfs functionality and disabled the unit test for it. Since vfs isn't part of what we release and no one appears to be working on or using vfs, this doesn't really bother me. The functionality wouldn't be that hard to re-instate based on the old producer/consumer interfaces, if someone really wanted to.

comment:7 Changed 6 years ago by jesstess

Author: exarkunexarkun,jesstess
Keywords: review removed
Owner: set to Jean-Paul Calderone

I can't tell if this is a trick, but here's some feedback in the hopes that it will help web2 die:

  • the StreamProducer and IByteStream imports were removed from ftp.py in 30707 but are still used in FTPReadVFS:
    twisted/vfs/adapters/ftp.py:270: undefined name 'StreamProducer'
    twisted/vfs/adapters/ftp.py:270: undefined name 'IByteStream'
    
  • There are a couple of lingering references to web2:
    ./twisted/python/zsh/_mktap:"web2:An HTTP/1.1 web server that can serve from a filesystem or application resource."
    ./twisted/python/zsh/_mktap:web2)
    ./twisted/python/zsh/_mktap:'--class=[A class that will be used to serve the root resource.  Must implement twisted.web2.iweb.IResource and take no arguments.]:class:_files' \
    ./twisted/python/zsh/_twistd:"web2:An HTTP/1.1 web server that can serve from a filesystem or application resource."
    ./twisted/python/zsh/_twistd:web2)
    ./twisted/python/zsh/_twistd:'--class=[A class that will be used to serve the root resource.  Must implement twisted.web2.iweb.IResource and take no arguments.]:class:_files' \
    ./twisted/web/_auth/__init__.py:HTTP header-based authentication migrated from web2
    ./twisted/web/test/test_cgi.py:    filters = sys.executable,  # web2's version
    
  • If there's not already a ticket for this, the website, including TwistedWebPlan, will need to get updated.

Other than that, the build looks fine.

comment:8 Changed 6 years ago by jesstess

Author: exarkun,jesstessexarkun
Cc: jesstess added

comment:9 Changed 6 years ago by Jean-Paul Calderone

(In [30898]) Remove web2 zsh completion information (manually, untested)

refs #4821

comment:10 Changed 6 years ago by Jean-Paul Calderone

Branch: branches/remove-web2-4821-2branches/remove-web2-4821-3

(In [30927]) Branching to 'remove-web2-4821-3'

comment:11 Changed 6 years ago by Jean-Paul Calderone

(In [30930]) Similar zsh completion info removal; untested, manual, like the _mktap change

refs #4821

comment:12 Changed 6 years ago by Jean-Paul Calderone

(In [30931]) Get rid of the thing for web2's version

refs #4821

comment:13 Changed 6 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

Thanks for the review! It is sort of difficult to decide if this ticket is a trick or not, I'm not entirely sure myself. :)

  1. Addressed vfs with #4934 (sort of cheating, but effective)
  2. Got rid of almost all those references, but I did leave behind the one in the web auth package, since it's still true.
  3. Good idea! I'll just go make some edits now, actually.

Here are the build results

comment:14 Changed 6 years ago by Glyph

Owner: set to Glyph
Status: newassigned

comment:15 Changed 6 years ago by Glyph

Keywords: review removed
Owner: changed from Glyph to Jean-Paul Calderone
Status: assignednew

CONGRATURATION, A WINNER IS YOU.

94 files changed, 12 insertions(+), 20256 deletions(-)

(Land.)

comment:16 Changed 6 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [30932]) Merge remove-web2-4821-3

Author: exarkun Reviewer: jesstess, glyph Fixes: #4821

Remove twisted.web2, unreleased, unmaintained, incomplete.

Note: See TracTickets for help on using tickets.