Ticket #4820 enhancement closed fixed

Opened 2 years ago

Last modified 2 years ago

Adding invite to IRCClient

Reported by: taos Owned by:
Priority: normal Milestone:
Component: words Keywords:
Cc: Branch: branches/ircclient-invite-4820
Author: taos Launchpad Bug:

Description

I think there should be a invite method to IRCClient.

Attachments

invite.patch Download (2.2 KB) - added by taos 2 years ago.
4820.feature Download (64 bytes) - added by taos 2 years ago.

Change History

Changed 2 years ago by taos

Changed 2 years ago by taos

1

Changed 2 years ago by taos

  • owner exarkun deleted
  • keywords review added

2

Changed 2 years ago by exarkun

  • branch set to branches/ircclient-invite-4820
  • branch_author set to exarkun

(In [30577]) Branching to 'ircclient-invite-4820'

3

Changed 2 years ago by exarkun

(In [30578]) Apply invite.patch

refs #4820

4

Changed 2 years ago by exarkun

  • branch_author changed from exarkun to taos

5

Changed 2 years ago by exarkun

  • owner set to exarkun
  • keywords review removed
  • status changed from new to assigned

Thanks for working on this patch. The implementation looks straightforward and correct to me. Concerning the tests though:

  1. I like ClientInviteTests, except for
    1. the lack of docstrings
    2. the testFoo naming (instead of the preferred test_foo style).
  2. Oops, also, the setUp call in testInvite isn't necessary. I think ClientTests.test_invite is probably redundant with the tests on ClientInviteTests though.
  3. methods should be separated from each other by two blank lines; classes by three.
  4. New APIs (like IRCClient.invite) should be marked up with @since tags

These are simple points, so I'll go ahead and correct them and then merge the change. Thanks again!

6

Changed 2 years ago by exarkun

(In [30580]) vertical whitespace fixes

refs #4820

7

Changed 2 years ago by exarkun

(In [30581]) @since marker

refs #4820

8

Changed 2 years ago by exarkun

(In [30582]) Add docstrings to everything on ClientInviteTests; fix vertical whitespace and test method naming; remove spurious setUp call; insert missing whitespace between function arguments.

refs #4820

9

Changed 2 years ago by exarkun

(In [30583]) Remove the redundant test_invite

refs #4820

10

Changed 2 years ago by exarkun

(In [30584]) restore deleted blank line

refs #4820

11

Changed 2 years ago by exarkun

  • status changed from assigned to closed
  • resolution set to fixed

(In [30585]) Merge ircclient-invite-4820

Author: taos, exarkun Reviewer: exarkun Fixes: #4820

Add IRCClient.invite method to send INVITE messages.

12

Changed 2 years ago by <automation>

  • owner exarkun deleted
Note: See TracTickets for help on using tickets.