_newclient.HTTP11ClientProtocol logs something awefully confusing in its write req errback

[djfroofy]

I'm not sure if there's meaning behind logging the word foo in log.err() call below? Perhaps this should be changed to something clearer.

      def ebRequestWriting(err):
            if self._state == 'TRANSMITTING':
                self._state = 'GENERATION_FAILED'
                self.transport.loseConnection()
                self._finishedRequest.errback(
                    Failure(RequestGenerationFailed([err])))
            else:
                log.err(err, "foo")

[djfroofy]

This makes logging a little clearer

[djfroofy]

Branch on launchpad

lp:~djfroofy/twisted/webclientlogging-4709

[jesstess]

(In [30272]) Branching to 'webclient-logging-4709'

[jesstess]

(In [30273]) Apply patch webclientlogging-4709.diff by djfroofy.

refs #4709

[jesstess]

(In [30276]) Merge webclient-logging-4709.

Author: djfroofy Reviewer: jesstess Fixes: #4709

In _newclient.HTTP11ClientProtocol, clarify the message logged when the connection is lost before generation fails.

[jesstess]

Thanks for the bug report, patch, and unit test, djfroofy!