Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4709 defect closed fixed (fixed)

_newclient.HTTP11ClientProtocol logs something awefully confusing in its write req errback

Reported by: djfroofy Owned by:
Priority: low Milestone:
Component: web Keywords:
Cc: jessica.mckellar@… Branch: branches/webclient-logging-4709
(diff, github, buildbot, log)
Author: jesstess Launchpad Bug:

Description

I'm not sure if there's meaning behind logging the word foo in log.err() call below? Perhaps this should be changed to something clearer.

      def ebRequestWriting(err):
            if self._state == 'TRANSMITTING':
                self._state = 'GENERATION_FAILED'
                self.transport.loseConnection()
                self._finishedRequest.errback(
                    Failure(RequestGenerationFailed([err])))
            else:
                log.err(err, "foo")

Attachments (1)

webclientlogging-4709.diff (2.0 KB) - added by djfroofy 4 years ago.
This makes logging a little clearer

Download all attachments as: .zip

Change History (10)

Changed 4 years ago by djfroofy

This makes logging a little clearer

comment:1 Changed 4 years ago by djfroofy

  • Keywords review added
  • Owner changed from jknight to exarkun

comment:2 Changed 4 years ago by djfroofy

Branch on launchpad

lp:~djfroofy/twisted/webclientlogging-4709

comment:3 Changed 4 years ago by exarkun

  • Owner exarkun deleted

comment:4 Changed 4 years ago by exarkun

  • Type changed from enhancement to defect

comment:5 Changed 4 years ago by jesstess

  • Author set to jesstess
  • Branch set to branches/webclient-logging-4709

(In [30272]) Branching to 'webclient-logging-4709'

comment:6 Changed 4 years ago by jesstess

(In [30273]) Apply patch webclientlogging-4709.diff by djfroofy.

refs #4709

comment:7 Changed 4 years ago by jesstess

  • Resolution set to fixed
  • Status changed from new to closed

(In [30276]) Merge webclient-logging-4709.

Author: djfroofy
Reviewer: jesstess
Fixes: #4709

In _newclient.HTTP11ClientProtocol, clarify the message logged when
the connection is lost before generation fails.

comment:8 Changed 4 years ago by jesstess

  • Cc jessica.mckellar@… added
  • Keywords review removed

Thanks for the bug report, patch, and unit test, djfroofy!

comment:9 Changed 4 years ago by <automation>

Note: See TracTickets for help on using tickets.