Ticket #4709 defect closed fixed

Opened 3 years ago

Last modified 3 years ago

_newclient.HTTP11ClientProtocol logs something awefully confusing in its write req errback

Reported by: djfroofy Owned by:
Priority: low Milestone:
Component: web Keywords:
Cc: jessica.mckellar@… Branch: branches/webclient-logging-4709
(diff, github, buildbot, log)
Author: jesstess Launchpad Bug:

Description

I'm not sure if there's meaning behind logging the word foo in log.err() call below? Perhaps this should be changed to something clearer.

      def ebRequestWriting(err):
            if self._state == 'TRANSMITTING':
                self._state = 'GENERATION_FAILED'
                self.transport.loseConnection()
                self._finishedRequest.errback(
                    Failure(RequestGenerationFailed([err])))
            else:
                log.err(err, "foo")

Attachments

webclientlogging-4709.diff Download (2.0 KB) - added by djfroofy 3 years ago.
This makes logging a little clearer

Change History

Changed 3 years ago by djfroofy

This makes logging a little clearer

1

Changed 3 years ago by djfroofy

  • owner changed from jknight to exarkun
  • keywords review added

2

Changed 3 years ago by djfroofy

Branch on launchpad

lp:~djfroofy/twisted/webclientlogging-4709

3

Changed 3 years ago by exarkun

  • owner exarkun deleted

4

Changed 3 years ago by exarkun

  • type changed from enhancement to defect

5

Changed 3 years ago by jesstess

  • branch set to branches/webclient-logging-4709
  • branch_author set to jesstess

(In [30272]) Branching to 'webclient-logging-4709'

6

Changed 3 years ago by jesstess

(In [30273]) Apply patch webclientlogging-4709.diff by djfroofy.

refs #4709

7

Changed 3 years ago by jesstess

  • status changed from new to closed
  • resolution set to fixed

(In [30276]) Merge webclient-logging-4709.

Author: djfroofy Reviewer: jesstess Fixes: #4709

In _newclient.HTTP11ClientProtocol, clarify the message logged when the connection is lost before generation fails.

8

Changed 3 years ago by jesstess

  • cc jessica.mckellar@… added
  • keywords review removed

Thanks for the bug report, patch, and unit test, djfroofy!

9

Changed 3 years ago by <automation>

Note: See TracTickets for help on using tickets.