Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#4709 defect closed fixed (fixed)

_newclient.HTTP11ClientProtocol logs something awefully confusing in its write req errback

Reported by: Drew Smathers Owned by:
Priority: low Milestone:
Component: web Keywords:
Cc: jesstess Branch: branches/webclient-logging-4709
branch-diff, diff-cov, branch-cov, buildbot
Author: jesstess

Description

I'm not sure if there's meaning behind logging the word foo in log.err() call below? Perhaps this should be changed to something clearer.

      def ebRequestWriting(err):
            if self._state == 'TRANSMITTING':
                self._state = 'GENERATION_FAILED'
                self.transport.loseConnection()
                self._finishedRequest.errback(
                    Failure(RequestGenerationFailed([err])))
            else:
                log.err(err, "foo")

Attachments (1)

webclientlogging-4709.diff (2.0 KB) - added by Drew Smathers 6 years ago.
This makes logging a little clearer

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by Drew Smathers

Attachment: webclientlogging-4709.diff added

This makes logging a little clearer

comment:1 Changed 6 years ago by Drew Smathers

Keywords: review added
Owner: changed from jknight to Jean-Paul Calderone

comment:2 Changed 6 years ago by Drew Smathers

Branch on launchpad

lp:~djfroofy/twisted/webclientlogging-4709

comment:3 Changed 6 years ago by Jean-Paul Calderone

Owner: Jean-Paul Calderone deleted

comment:4 Changed 6 years ago by Jean-Paul Calderone

Type: enhancementdefect

comment:5 Changed 6 years ago by jesstess

Author: jesstess
Branch: branches/webclient-logging-4709

(In [30272]) Branching to 'webclient-logging-4709'

comment:6 Changed 6 years ago by jesstess

(In [30273]) Apply patch webclientlogging-4709.diff by djfroofy.

refs #4709

comment:7 Changed 6 years ago by jesstess

Resolution: fixed
Status: newclosed

(In [30276]) Merge webclient-logging-4709.

Author: djfroofy Reviewer: jesstess Fixes: #4709

In _newclient.HTTP11ClientProtocol, clarify the message logged when the connection is lost before generation fails.

comment:8 Changed 6 years ago by jesstess

Cc: jesstess added
Keywords: review removed

Thanks for the bug report, patch, and unit test, djfroofy!

comment:9 Changed 6 years ago by <automation>

Note: See TracTickets for help on using tickets.