Opened 7 years ago

Last modified 4 years ago

#4672 task new

Convert libglade files to gtkbuilder files

Reported by: Jonathan Lange Owned by: Thijs Triemstra
Priority: lowest Milestone:
Component: core Keywords:
Cc: Thijs Triemstra Branch: branches/glade-gtkbuilder-4672
branch-diff, diff-cov, branch-cov, buildbot
Author: thijs

Description (last modified by Thijs Triemstra)

Gtk added support for gtkbuilder files in 2.12, deprecating the need for libglade.

We should probably bring our glade files up to date. Also see http://stackoverflow.com/questions/1412350/modifying-a-gui-started-with-glade.

$ find . -name '*glade'
./doc/core/examples/pbgtk2login.glade
./twisted/spread/ui/login2.glade
./twisted/words/im/instancemessenger.glade
./twisted/manhole/gladereactor.glade
./twisted/manhole/logview.glade
./twisted/manhole/inspectro.glade
./twisted/manhole/ui/gtk2manhole.glade

Attachments (1)

glade-gtkbuilder-4672.patch (31.9 KB) - added by Thijs Triemstra 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by Jean-Paul Calderone

Priority: normallowest

Assigning a priority consistent with the explanation at http://www.micahcarrick.com/gtk-builder-libglade-faq.html

comment:2 Changed 6 years ago by <automation>

Owner: Glyph deleted

Changed 5 years ago by Thijs Triemstra

Attachment: glade-gtkbuilder-4672.patch added

comment:3 Changed 5 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review added

When trying to close the doc/core/examples/pbgtk2.py example it prints the following traceback:

Traceback (most recent call last):
  File "doc/core/examples/pbgtk2.py", line 48, in on_loginDialog_response
    handlers.get(response)()
  File "doc/core/examples/pbgtk2.py", line 55, in cancelled
    self.deferredResult.errback()
  File "/home/thijs/workspaces/opensource/Twisted/trunk/twisted/internet/defer.py", line 393, in errback
    fail = failure.Failure(captureVars=self.debug)
  File "/home/thijs/workspaces/opensource/Twisted/trunk/twisted/python/failure.py", line 217, in __init__
    raise NoCurrentExceptionError()
twisted.python.failure.NoCurrentExceptionError

When I convert the glade file to a gtkbuilder file the traceback is the same so this means it's not related to the conversion. Not sure what goes wrong here, any pointers are appreciated.

Attached patch adds the converted file and changes to the example. I suggest opening additional tickets for the other glade files to limit the scope of this ticket.

comment:4 Changed 5 years ago by Thijs Triemstra

Description: modified (diff)

comment:5 Changed 5 years ago by washort

How is this patch related to the error you list there? Does it fix the problem?

comment:6 Changed 4 years ago by Jean-Paul Calderone

The error is an unrelated bug in the pbgtk2.py example.

comment:7 Changed 4 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to Thijs Triemstra

Unfortunately the bulk of this patch no longer applies. There's a big conflict in pbgtk2.py with the part of the code that actually switches to Builder.

comment:8 Changed 4 years ago by Thijs Triemstra

Author: thijs
Branch: branches/glade-gtkbuilder-4672

(In [36829]) Branching to 'glade-gtkbuilder-4672'

Note: See TracTickets for help on using tickets.