Ticket #4672 task new

Opened 4 years ago

Last modified 15 months ago

Convert libglade files to gtkbuilder files

Reported by: jml Owned by: thijs
Priority: lowest Milestone:
Component: core Keywords:
Cc: thijs Branch: branches/glade-gtkbuilder-4672
(diff, github, buildbot, log)
Author: thijs Launchpad Bug:

Description (last modified by thijs) (diff)

Gtk added support for gtkbuilder files in 2.12, deprecating the need for libglade.

We should probably bring our glade files up to date. Also see  http://stackoverflow.com/questions/1412350/modifying-a-gui-started-with-glade.

$ find . -name '*glade'
./doc/core/examples/pbgtk2login.glade
./twisted/spread/ui/login2.glade
./twisted/words/im/instancemessenger.glade
./twisted/manhole/gladereactor.glade
./twisted/manhole/logview.glade
./twisted/manhole/inspectro.glade
./twisted/manhole/ui/gtk2manhole.glade

Attachments

glade-gtkbuilder-4672.patch Download (31.9 KB) - added by thijs 2 years ago.

Change History

1

Changed 4 years ago by exarkun

  • priority changed from normal to lowest

Assigning a priority consistent with the explanation at  http://www.micahcarrick.com/gtk-builder-libglade-faq.html

2

Changed 3 years ago by <automation>

  • owner glyph deleted

Changed 2 years ago by thijs

3

Changed 2 years ago by thijs

  • cc thijs added
  • keywords review added

When trying to close the doc/core/examples/pbgtk2.py example it prints the following traceback:

Traceback (most recent call last):
  File "doc/core/examples/pbgtk2.py", line 48, in on_loginDialog_response
    handlers.get(response)()
  File "doc/core/examples/pbgtk2.py", line 55, in cancelled
    self.deferredResult.errback()
  File "/home/thijs/workspaces/opensource/Twisted/trunk/twisted/internet/defer.py", line 393, in errback
    fail = failure.Failure(captureVars=self.debug)
  File "/home/thijs/workspaces/opensource/Twisted/trunk/twisted/python/failure.py", line 217, in __init__
    raise NoCurrentExceptionError()
twisted.python.failure.NoCurrentExceptionError

When I convert the glade file to a gtkbuilder file the traceback is the same so this means it's not related to the conversion. Not sure what goes wrong here, any pointers are appreciated.

Attached patch adds the converted file and changes to the example. I suggest opening additional tickets for the other glade files to limit the scope of this ticket.

4

Changed 2 years ago by thijs

  • description modified (diff)

5

Changed 18 months ago by washort

How is this patch related to the error you list there? Does it fix the problem?

6

Changed 15 months ago by exarkun

The error is an unrelated bug in the pbgtk2.py example.

7

Changed 15 months ago by exarkun

  • keywords review removed
  • owner set to thijs

Unfortunately the bulk of this patch no longer applies. There's a big conflict in pbgtk2.py with the part of the code that actually switches to Builder.

8

Changed 15 months ago by thijs

  • branch set to branches/glade-gtkbuilder-4672
  • branch_author set to thijs

(In [36829]) Branching to 'glade-gtkbuilder-4672'

Note: See TracTickets for help on using tickets.