Opened 4 years ago

Closed 4 years ago

#4564 enhancement closed fixed (fixed)

Factor _trial_temp directory creation and cleanup so as to be re-usable by multiple runner implementations

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: trial Keywords:
Cc: Branch: branches/trial-temp-reusage-4564
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

TrialRunner has various logic for selecting a _trial_temp[-N] directory, cleaning up what was there before, creating a new one, and changing the current working directory to be it.

This is probably generally useful to runner implementations. As it happens, #1784 (disttrial) introduces a new runner implementation which benefits from being able to use this code.

Change History (8)

comment:1 Changed 4 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/trial-temp-reusage-4564

(In [29751]) Branching to 'trial-temp-reusage-4564'

comment:2 Changed 4 years ago by exarkun

  • Keywords review added
  • Owner jml deleted

Pulled the code out of the disttrial branch, cleaned it up a bit. Please review.

comment:3 Changed 4 years ago by exarkun

  • Summary changed from Factory _trial_temp directory creation and cleanup so as to be re-usable by multiple runner implementations to Factor _trial_temp directory creation and cleanup so as to be re-usable by multiple runner implementations

comment:4 Changed 4 years ago by exarkun

(In [29757]) Drop this refactoring; see #4564.

comment:5 Changed 4 years ago by Screwtape

  • Owner set to Screwtape
  • Status changed from new to assigned

comment:6 Changed 4 years ago by Screwtape

  • Keywords review removed
  • Owner changed from Screwtape to exarkun
  • Status changed from assigned to new

Looks good to me, go ahead and merge.

comment:7 Changed 4 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [29851]) Merge trial-temp-reusage-4564

Author: exarkun
Reviewer: screwtape
Fixes: #4564

Factor _trial_temp creation and cleanup code out of the runner so it can
be re-used by another runner implementation.

comment:8 Changed 3 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.