Ticket #4564 enhancement closed fixed

Opened 3 years ago

Last modified 3 years ago

Factor _trial_temp directory creation and cleanup so as to be re-usable by multiple runner implementations

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: trial Keywords:
Cc: Branch: branches/trial-temp-reusage-4564
Author: exarkun Launchpad Bug:

Description

TrialRunner has various logic for selecting a _trial_temp[-N] directory, cleaning up what was there before, creating a new one, and changing the current working directory to be it.

This is probably generally useful to runner implementations. As it happens, #1784 (disttrial) introduces a new runner implementation which benefits from being able to use this code.

Change History

1

Changed 3 years ago by exarkun

  • branch set to branches/trial-temp-reusage-4564
  • branch_author set to exarkun

(In [29751]) Branching to 'trial-temp-reusage-4564'

2

Changed 3 years ago by exarkun

  • keywords review added
  • owner jml deleted

Pulled the code out of the disttrial branch, cleaned it up a bit. Please review.

3

Changed 3 years ago by exarkun

  • summary changed from Factory _trial_temp directory creation and cleanup so as to be re-usable by multiple runner implementations to Factor _trial_temp directory creation and cleanup so as to be re-usable by multiple runner implementations

4

Changed 3 years ago by exarkun

(In [29757]) Drop this refactoring; see #4564.

5

Changed 3 years ago by Screwtape

  • owner set to Screwtape
  • status changed from new to assigned

6

Changed 3 years ago by Screwtape

  • owner changed from Screwtape to exarkun
  • status changed from assigned to new
  • keywords review removed

Looks good to me, go ahead and merge.

7

Changed 3 years ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [29851]) Merge trial-temp-reusage-4564

Author: exarkun Reviewer: screwtape Fixes: #4564

Factor _trial_temp creation and cleanup code out of the runner so it can be re-used by another runner implementation.

8

Changed 2 years ago by <automation>

  • owner exarkun deleted
Note: See TracTickets for help on using tickets.