Opened 6 years ago

Closed 6 years ago

#4564 enhancement closed fixed (fixed)

Factor _trial_temp directory creation and cleanup so as to be re-usable by multiple runner implementations

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: trial Keywords:
Cc: Branch: branches/trial-temp-reusage-4564
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

TrialRunner has various logic for selecting a _trial_temp[-N] directory, cleaning up what was there before, creating a new one, and changing the current working directory to be it.

This is probably generally useful to runner implementations. As it happens, #1784 (disttrial) introduces a new runner implementation which benefits from being able to use this code.

Change History (8)

comment:1 Changed 6 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/trial-temp-reusage-4564

(In [29751]) Branching to 'trial-temp-reusage-4564'

comment:2 Changed 6 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jonathan Lange deleted

Pulled the code out of the disttrial branch, cleaned it up a bit. Please review.

comment:3 Changed 6 years ago by Jean-Paul Calderone

Summary: Factory _trial_temp directory creation and cleanup so as to be re-usable by multiple runner implementationsFactor _trial_temp directory creation and cleanup so as to be re-usable by multiple runner implementations

comment:4 Changed 6 years ago by Jean-Paul Calderone

(In [29757]) Drop this refactoring; see #4564.

comment:5 Changed 6 years ago by Screwtape

Owner: set to Screwtape
Status: newassigned

comment:6 Changed 6 years ago by Screwtape

Keywords: review removed
Owner: changed from Screwtape to Jean-Paul Calderone
Status: assignednew

Looks good to me, go ahead and merge.

comment:7 Changed 6 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [29851]) Merge trial-temp-reusage-4564

Author: exarkun Reviewer: screwtape Fixes: #4564

Factor _trial_temp creation and cleanup code out of the runner so it can be re-used by another runner implementation.

comment:8 Changed 6 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.