Ticket #4563 enhancement closed fixed

Opened 3 years ago

Last modified 3 years ago

Save the specified reactor in ReactorSelectionMixin for later inspection

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: core Keywords: easy
Cc: Branch: branches/save-reactor-option-4563
Author: exarkun Launchpad Bug:

Description

ReactorSelectionMixin gives an Options subclass options for listing and installing a particular reactor. To ensure that the reactor has the greatest chance of being successfully installed, it installs it while the option parsing is happening. This is cool.

However, it means that no "reactor" key is ever added to the Options instance, so it's hard to tell which reactor was installed.

In particular, disttrial (#1784) is interested in this so that it can configure the test runner processes it creates to use the same reactor.

Change History

1

Changed 3 years ago by exarkun

  • branch set to branches/save-reactor-option-4563
  • branch_author set to exarkun

(In [29745]) Branching to 'save-reactor-option-4563'

2

Changed 3 years ago by exarkun

  • owner exarkun deleted
  • keywords review easy added

Pulled the change out of the disttrial branch and added a test and documentation.

3

Changed 3 years ago by exarkun

(In [29750]) Drop this, see #4563

4

Changed 3 years ago by therve

  • owner set to exarkun
  • keywords review removed

Please merge.

5

Changed 3 years ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [29818]) Merge save-reactor-option-4563

Author: exarkun Reviewer: therve Fixes: #4563

Enhance twisted.application.app.ReactorSelectionMixin so that it saves the selected reactor name for later inspection.

6

Changed 2 years ago by <automation>

  • owner exarkun deleted
Note: See TracTickets for help on using tickets.