Opened 4 years ago

Closed 4 years ago

#4563 enhancement closed fixed (fixed)

Save the specified reactor in ReactorSelectionMixin for later inspection

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: core Keywords: easy
Cc: Branch: branches/save-reactor-option-4563
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

ReactorSelectionMixin gives an Options subclass options for listing and installing a particular reactor. To ensure that the reactor has the greatest chance of being successfully installed, it installs it while the option parsing is happening. This is cool.

However, it means that no "reactor" key is ever added to the Options instance, so it's hard to tell which reactor was installed.

In particular, disttrial (#1784) is interested in this so that it can configure the test runner processes it creates to use the same reactor.

Change History (6)

comment:1 Changed 4 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/save-reactor-option-4563

(In [29745]) Branching to 'save-reactor-option-4563'

comment:2 Changed 4 years ago by exarkun

  • Keywords review easy added
  • Owner exarkun deleted

Pulled the change out of the disttrial branch and added a test and documentation.

comment:3 Changed 4 years ago by exarkun

(In [29750]) Drop this, see #4563

comment:4 Changed 4 years ago by therve

  • Keywords review removed
  • Owner set to exarkun

Please merge.

comment:5 Changed 4 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [29818]) Merge save-reactor-option-4563

Author: exarkun
Reviewer: therve
Fixes: #4563

Enhance twisted.application.app.ReactorSelectionMixin so that it saves
the selected reactor name for later inspection.

comment:6 Changed 4 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.