Ticket #4562 defect closed fixed

Opened 3 years ago

Last modified 3 years ago

Cyclic dependency between twisted.test.test_failure and twisted.test.generator_failure_tests

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: jessica.mckellar@… Branch: branches/generator-tests-cycle-4562
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

test_failure imports generator_failure_tests. generator_failure_tests imports test_failure. This works as long as test_failure gets loaded first, but fails as soon as you try to start with generator_failure_tests (which you can observe by picking them specifically with trial: trial twisted.test.generator_failure_tests).

The dependency is really shallow though, so it should be easy to fix.

This is something that was discovered in the #1784, and the fix is pulled straight from that branch as well.

Change History

1

Changed 3 years ago by exarkun

  • branch set to branches/generator-tests-cycle-4562
  • branch_author set to exarkun

(In [29737]) Branching to 'generator-tests-cycle-4562'

2

Changed 3 years ago by exarkun

  • keywords easy review added
  • owner exarkun deleted

3

Changed 3 years ago by exarkun

(In [29756]) Drop this; see #4562.

4

Changed 3 years ago by jesstess

  • cc jessica.mckellar@… added
  • owner set to exarkun
  • keywords tests easy review removed

Thanks for fixing this, exarkun. Looks good to merge.

5

Changed 3 years ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [29772]) Merge generator-tests-cycle-4562

Author: exarkun Reviewer: jesstess Fixes: #4562

Remove the circular dependency between twisted.test.test_failure and twisted.test.generator_failure_tests.

6

Changed 2 years ago by <automation>

  • owner exarkun deleted
Note: See TracTickets for help on using tickets.