Opened 4 years ago

Closed 4 years ago

#4562 defect closed fixed (fixed)

Cyclic dependency between twisted.test.test_failure and twisted.test.generator_failure_tests

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: jessica.mckellar@… Branch: branches/generator-tests-cycle-4562
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

test_failure imports generator_failure_tests. generator_failure_tests imports test_failure. This works as long as test_failure gets loaded first, but fails as soon as you try to start with generator_failure_tests (which you can observe by picking them specifically with trial: trial twisted.test.generator_failure_tests).

The dependency is really shallow though, so it should be easy to fix.

This is something that was discovered in the #1784, and the fix is pulled straight from that branch as well.

Change History (6)

comment:1 Changed 4 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/generator-tests-cycle-4562

(In [29737]) Branching to 'generator-tests-cycle-4562'

comment:2 Changed 4 years ago by exarkun

  • Keywords easy review added
  • Owner exarkun deleted

comment:3 Changed 4 years ago by exarkun

(In [29756]) Drop this; see #4562.

comment:4 Changed 4 years ago by jesstess

  • Cc jessica.mckellar@… added
  • Keywords tests easy review removed
  • Owner set to exarkun

Thanks for fixing this, exarkun. Looks good to merge.

comment:5 Changed 4 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [29772]) Merge generator-tests-cycle-4562

Author: exarkun
Reviewer: jesstess
Fixes: #4562

Remove the circular dependency between twisted.test.test_failure
and twisted.test.generator_failure_tests.

comment:6 Changed 4 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.