Ticket #4546 task closed fixed

Opened 3 years ago

Last modified 3 years ago

Remove deprecated SafeNetstringReceiver

Reported by: thijs Owned by:
Priority: lowest Milestone:
Component: core Keywords: easy
Cc: thijs, jessica.mckellar@… Branch: branches/remove-SafeNetstringReceiver-4546
Author: Launchpad Bug:

Description

Looks like SafeNetstringReceiver in trunk/twisted/protocols/basic.py was added as deprecated (?) in r591, let's remove it.

Change History

1

Changed 3 years ago by exarkun

  • priority changed from normal to lowest

2

Changed 3 years ago by cyli

(In [30166]) Removed twisted.protocols.basic.SafeNetstringReceiver. Refs #4546

3

Changed 3 years ago by cyli

  • owner cyli deleted
  • keywords easy review added
  • branch set to branches/remove-SafeNetstringReceiver-4546

Up for review. Strangely, trac didn't pick up the branch creation. The branch is here: http://twistedmatrix.com/trac/browser/branches/remove-SafeNetstringReceiver-4546

4

Changed 3 years ago by cyli

 build results

5

Changed 3 years ago by cyli

 second build where that one failing test passed

6

Changed 3 years ago by cyli

(In [30179]) Changed newsfile to conform with accepted format.

Refs #4546

7

Changed 3 years ago by jesstess

  • keywords review removed
  • cc jessica.mckellar@… added
  • owner set to cyli

Thanks for working on this, cyli. Looks great, please merge!

8

Changed 3 years ago by cyli

Thanks for the review! Merging.

9

Changed 3 years ago by cyli

  • status changed from new to closed
  • resolution set to fixed

(In [30185]) Merge remove-SafeNetstringReceiver-4546: remove twisted.protocols.basic.SafeNetstringReceiver

Author: cyli Reviewer: jesstess Fixes: #4546

Remove twisted.protocols.basic.SafeNetstringReceiver, which has been deprecated since 2001

10

Changed 2 years ago by <automation>

  • owner cyli deleted
Note: See TracTickets for help on using tickets.