Deprecate or remove unused warnings and exceptions in twisted.trial.util

[cyli]

FailureError, DirtyReactorWarning, DirtyReactorError, PendingTimedCallsError have been deprecated since Twisted 8.0, although the deprecation was stated in a docstring rather than as a warning.

This should either be deprecated correctly (via warnings) or removed. Removing them does not seem to affect any tests.

[cyli]

I am in favor of removal, as it is simpler. Also, the docstring for twisted.trial.util say that it is a module for internal use only.

[jesstess]

(In [29309]) Branching to 'remove-trialutil-exceptions-4505'

[jesstess]

(In [29310]) Apply patch 4505.diff by cyli.

refs #4505

[jesstess]

Thanks for tackling all these deprecations and removals, cyli!

Given the "This code is for Trial's internal use. Do NOT use this code if you are writing tests. It is subject to change at the Trial maintainer's whim." disclaimer at the top of util.py, I agree with removal instead of deprecation.

Some feedback:

• In the topfile, the message is duplicated.
• In util.py, pyflakes catches that _ _all_ _ still references the removed Exceptions.
• There are still references to DirtyReactorError in twisted/trial/test/test_reporter.py and twisted/trial/reporter.py

[cyli]

(In [29313]) Bump copyright (previous commit: fixes for review)

refs #4505

[cyli]

* In the topfile, the message is duplicated.

Huh, odd, it wasn't in the diff. Fixed though.

* In util.py, pyflakes catches that _ _all_ _ still references the removed Exceptions.

Removed.

* There are still references to DirtyReactorError in twisted/trial/test/test_reporter.py and twisted/trial/reporter.py

Looks like someone forgot to modify the comments when they changed over from using DirtyReactorError to using DirtyReactorAggregateError. Fixed.

[jesstess]

C{DirtyReactorAggregateError} might as well be L{DirtyReactorAggregateError} in test_warningsEnabled and test_warningsMaskErrors. Other than that, I think this good to merge.

[cyli]

(In [29316]) Updated C{DirtyReactorAggregateError} to L{DirtyReactorAggregateError}

refs #4505

[cyli]

(In [29317]) Merge remove-trialutil-exceptions-4505 : remove deprecated exceptions in t.trial.util

Author: cyli Reviewer: jesstess Fixes: #4505

Remove deprecated warnings and exceptions from t.trial.util, as well as some comments in t.trial.reporter and t.trial.test.test_reporter

[cyli]

Thanks for the quick turnaround time!