ListOf AMP Arguments should support 'optional' flag
|Reported by:||faldridge||Owned by:|
Like all other AMP Argument subclasses, t.p.amp.ListOf should allow callers to pass 'optional=True' to its init() method, thereby allowing the argument to be omitted from the protocol.
Attached is a patch that provides the correct behavior with the necessary update to ListOf's docstring.
As the functionality is handled by the base class (t.p.amp.Argument), and not individual subclasses, and as the functionality already has unit tests, there are no unit tests included in this patch.
Change History (6)
comment:1 follow-up: ↓ 2 Changed 4 years ago by exarkun
- Keywords review removed
- Owner changed from glyph to faldridge
Changed 4 years ago by faldridge
comment:2 in reply to: ↑ 1 Changed 4 years ago by faldridge
- Keywords review added
- Owner changed from faldridge to exarkun