IMAP4 server loops indefinitely if a search query yields more than 4 items

[wulczer]

The responsible code seems to be

if i == 4:
    from twisted.internet import reactor
    reactor.callLater(
        0, self.__cbManualSearch, result, tag, mbox, query, uid,
        searchResults)

in IMAP4Server.cbManualSearch.

It seems to me that it should be slicing the first four items off the result list before calling itself again.

[wulczer]

patch to fix the issue

[therve]

DefaultSearchTestCase.test_searchAndMessageSet is freezing for me. The patch doesn't seem to be again latest trunk, maybe it's the problem?

[wulczer]

rebased patch to trunk

[wulczer]

Replying to therve:

DefaultSearchTestCase.test_searchAndMessageSet is freezing for me. The patch doesn't seem to be again latest trunk, maybe it's the problem?

Yes, you're right, the patch was bad. I rebased it against latest trunk (attached).

[exarkun]

Thanks. The patch looks good. I'll apply it.

[exarkun]

(In [28818]) Apply twisted-4385-imap4-loop-v2.patch to fix the infinite loop in IMAP4 server search handling

Author: wulczer Reviewer: therve, exarkun Fixes: #4385

Previously the fallback search implementation provided by IMAP4Server would examine the first five messages in a mailbox forever, trying to respond to a search command. This fixes it to actually iterate over all the messages in the mailbox and eventually complete.