Ticket #4363 task closed fixed

Opened 3 years ago

Last modified 2 years ago

Remove twisted.words.protocols.toc

Reported by: amacleod Owned by:
Priority: low Milestone:
Component: words Keywords:
Cc: thijs, jesstess Branch: branches/remove-toc-4363
(diff, github, buildbot, log)
Author: thijs Launchpad Bug:

Description

We should get rid of twisted.words.protocols.toc. It has been deprecated in #3580. Per exarkun in #4007, the earliest that toc can be removed would be after December of 2010.

As soon as this ticket is resolved, also do #4007.

Change History

1

Changed 3 years ago by thijs

  • cc thijs, jesstess added
  • summary changed from Remove TOC to Remove twisted.words.protocols.toc

Closed #2236 as a result of this ticket.

2

Changed 3 years ago by exarkun

  • owner changed from exarkun to thijs

3

Changed 2 years ago by thijs

  • branch set to branches/remove-toc-4363
  • branch_author set to thijs

(In [30521]) Branching to 'remove-toc-4363'

4

Changed 2 years ago by thijs

(In [30522]) Remove deprecated t.w.p.toc. refs #4363

5

Changed 2 years ago by thijs

  • keywords review added
  • owner thijs deleted

6

Changed 2 years ago by thijs

#4007 is also up for review.

7

Changed 2 years ago by cyli

  • keywords review removed
  • owner set to thijs
  1. You should also remove twisted.words.toctap (since that is a plugin for setting up a TOC server) and twisted.words.im.tocsupport.
  2. Once you remove twisted.words.toctap, could you also remove the twisted.plugins.twisted_words reference to toctap and update the copyright?

Thank you for working on this thijs!

8

Changed 2 years ago by thijs

  • status changed from new to assigned

9

Changed 2 years ago by thijs

(In [30539]) Remove toctap, refs #4363

10

Changed 2 years ago by thijs

  • owner thijs deleted
  • status changed from assigned to new
  • keywords review added

Doc builder looks  ok.

11

Changed 2 years ago by thijs

(In [30540]) update copyright, refs #4363

12

Changed 2 years ago by cyli

  • owner set to thijs
  • keywords review removed

It is 2011 now, but other than that, it looks good and the  tests pass. Please merge after the change from 2010 to 2011. :) Thanks!

13

Changed 2 years ago by thijs

  • status changed from new to closed
  • resolution set to fixed

(In [30543]) Merge remove-toc-4363: Remove twisted.words.protocols.toc, that was largely non-working and useless since AOL disabled TOC on their AIM network.

Author: thijs Reviewer: cyli Fixes: #4363

14

Changed 2 years ago by <automation>

  • owner thijs deleted
Note: See TracTickets for help on using tickets.