Opened 4 years ago

Closed 4 years ago

#4363 task closed fixed (fixed)

Remove twisted.words.protocols.toc

Reported by: amacleod Owned by:
Priority: low Milestone:
Component: words Keywords:
Cc: thijs, jesstess Branch: branches/remove-toc-4363
(diff, github, buildbot, log)
Author: thijs Launchpad Bug:

Description

We should get rid of twisted.words.protocols.toc. It has been deprecated in #3580. Per exarkun in #4007, the earliest that toc can be removed would be after December of 2010.

As soon as this ticket is resolved, also do #4007.

Change History (14)

comment:1 Changed 4 years ago by thijs

  • Cc thijs jesstess added
  • Summary changed from Remove TOC to Remove twisted.words.protocols.toc

Closed #2236 as a result of this ticket.

comment:2 Changed 4 years ago by exarkun

  • Owner changed from exarkun to thijs

comment:3 Changed 4 years ago by thijs

  • Author set to thijs
  • Branch set to branches/remove-toc-4363

(In [30521]) Branching to 'remove-toc-4363'

comment:4 Changed 4 years ago by thijs

(In [30522]) Remove deprecated t.w.p.toc. refs #4363

comment:5 Changed 4 years ago by thijs

  • Keywords review added
  • Owner thijs deleted

comment:6 Changed 4 years ago by thijs

#4007 is also up for review.

comment:7 Changed 4 years ago by cyli

  • Keywords review removed
  • Owner set to thijs
  1. You should also remove twisted.words.toctap (since that is a plugin for setting up a TOC server) and twisted.words.im.tocsupport.
  2. Once you remove twisted.words.toctap, could you also remove the twisted.plugins.twisted_words reference to toctap and update the copyright?

Thank you for working on this thijs!

comment:8 Changed 4 years ago by thijs

  • Status changed from new to assigned

comment:9 Changed 4 years ago by thijs

(In [30539]) Remove toctap, refs #4363

comment:10 Changed 4 years ago by thijs

  • Keywords review added
  • Owner thijs deleted
  • Status changed from assigned to new

Doc builder looks ok.

comment:11 Changed 4 years ago by thijs

(In [30540]) update copyright, refs #4363

comment:12 Changed 4 years ago by cyli

  • Keywords review removed
  • Owner set to thijs

It is 2011 now, but other than that, it looks good and the tests pass. Please merge after the change from 2010 to 2011. :) Thanks!

comment:13 Changed 4 years ago by thijs

  • Resolution set to fixed
  • Status changed from new to closed

(In [30543]) Merge remove-toc-4363: Remove twisted.words.protocols.toc, that was largely non-working and useless since AOL disabled TOC on their AIM network.

Author: thijs
Reviewer: cyli
Fixes: #4363

comment:14 Changed 4 years ago by <automation>

  • Owner thijs deleted
Note: See TracTickets for help on using tickets.