Opened 7 years ago

Closed 7 years ago

#4358 defect closed fixed (fixed)

Problems with conch examples

Reported by: cratuki Owned by:
Priority: normal Milestone:
Component: conch Keywords:
Cc: jesstess Branch:
Author: exarkun

Description

I was looking at conch examples found at http://twistedmatrix.com/documents/current/conch/examples/#auto2 on 20100307.

Problems:

1) Numbered links in first section of page don't navigate to new pages.

2) demo_draw doesn't work. It mentions insult dependencies in the stack trace. This may have been modified when someone thought they were working on demo_insults.trac.

3) For the last four, the service starts, but a telnet to the port gives the following output:

Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
SSH-2.0-Twisted
####
    #f#ju##p#
             1diffie-hellman-group1-sha1ssh-rsa#aes256-ctr,aes256-cbc,aes192-ctr,aes192-cbc,aes128-ctr,aes128-cbc,cast128-ctr,cast128-cbc,blowfish-ctr,blowfish-cbc,3des-ctr,3des-cbc#aes256-ctr,aes256-cbc,aes192-ctr,aes192-cbc,aes128-ctr,aes128-cbc,cast128-ctr,cast128-cbc,blowfish-ctr,blowfish-cbc,3des-ctr,3des-cbchmac-sha1,hmac-md5hmac-sha1,hmac-md5     none,zlib       none,zlib#;Hk

It's unclear how to proceed past this.

4) It would be good to mention dependencies for the scripts in the files. I did this to get them working: . easy_install pyCrypto . easy_install pyasn1

Attachments (1)

irm.patch (499 bytes) - added by Jean-Paul Calderone 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by Glyph

Component: coreconch
Owner: changed from Glyph to z3p

comment:2 Changed 7 years ago by Jean-Paul Calderone

Owner: changed from z3p to Jean-Paul Calderone
Status: newassigned
  1. They're links to anchors on the same page.
  2. r14200 removed the module level IRM constant, breaking demo_draw.tac.
  3. That's the SSH port.
  4. twisted/conch/topfiles/README enumerates Conch's dependencies. I don't think we should duplicate the dependency information in N example files. Other suggestions welcome, though.

Changed 7 years ago by Jean-Paul Calderone

Attachment: irm.patch added

comment:3 Changed 7 years ago by Jean-Paul Calderone

Author: cratukiexarkun
Keywords: review added
Owner: Jean-Paul Calderone deleted
Status: assignednew

Attached fixes the example.

comment:4 Changed 7 years ago by jesstess

Cc: jesstess added
Keywords: review removed
Owner: set to Jean-Paul Calderone

I don't have the Crypto dependency to run the example right now, but assuming that it now runs without any problems, the change looks good. demo_draw.tac needs a copyright bump and moving the triple quotes to lines of their own, but other than that looks good to apply.

comment:5 Changed 7 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [28765]) Apply irm.patch fixing the insults drawing example

Author: exarkun Reviewer: jesstess Fixes: #4358

Fix the usage of an insults API in the drawing example which was broken quite a long time ago. The new code uses the correct name for a constant to enable insertion replacement mode.

comment:6 Changed 7 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.