Opened 4 years ago

Closed 4 years ago

#4348 defect closed fixed (fixed)

Broken link to ITCPTransport API doc in core clients howto

Reported by: jesstess Owned by:
Priority: normal Milestone:
Component: core Keywords: easy
Cc: jesstess, thijs, kevin.horn@… Branch: branches/broken-client-link-4348
(diff, github, buildbot, log)
Author: jesstess Launchpad Bug:

Description


Change History (8)

comment:1 Changed 4 years ago by jesstess

  • Author set to jesstess
  • Branch set to branches/broken-client-link-4348

(In [28658]) Branching to 'broken-client-link-4348'

comment:2 Changed 4 years ago by jesstess

(In [28659]) Fix broken API link, remove trailing whitespace, spell check, add
markup, make logBot example code match the actual ircLogBot.py.

refs #4348

comment:3 Changed 4 years ago by jesstess

  • Cc jesstess added
  • Keywords review added
  • Owner jesstess deleted

comment:4 Changed 4 years ago by thijs

  • Cc thijs added
  • Keywords review removed
  • Owner set to jesstess

There's a sentence that goes "...sets on it an attribute called <code>factory</code>". What about "...sets a <code>factory</code> attribute (on it)".

If you think that's an improvement as well, please fix and then merge it, thanks.

comment:5 Changed 4 years ago by khorn

  • Cc kevin.horn@… added

comment:6 Changed 4 years ago by jesstess

(In [28750]) Reword how a factory's protocol has a reference to the factory so it
can access persistent state, as that does seem to confuse people.

refs #4348

comment:7 Changed 4 years ago by jesstess

  • Resolution set to fixed
  • Status changed from new to closed

(In [28752]) Merge broken-client-link-4348

Author: jesstess
Reviewer: thijs
Fixes: #4348

Fix broken API link, remove trailing whitespace, spell check, add
markup, make logBot example code match the actual ircLogBot.py.

comment:8 Changed 4 years ago by <automation>

  • Owner jesstess deleted
Note: See TracTickets for help on using tickets.