Changes between and of Initial VersionVersion 22Ticket #4330


Ignore:
Timestamp:
05/30/2013 11:03:14 AM (14 months ago)
Author:
itamar
Comment:

Thanks for the update!

  1. Cancelling when in TRANSMITTING eventually results in loseConnection(); this should really be abortConnection(). I believe the relevant code is ebRequestWriting in HTTP11ClientProtocol.request.
  2. For completeness sake it might be worth testing that cancellation works during the connection process, i.e. that HTTPConnectionPool.getConnection results are cancellable... but that just devolves to endpoint cancellation. So not sure quite what to do here. Probably nothing.
  3. The auto-retry code in _RetryingHTTP11ClientProtocol._shouldRetry should be modified so it does not retry if the reason for failure was cancellation.
  4. File a ticket for making the result of FileBodyProducer.startProducing cancellable.

I will address these comments and resubmit for review.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4330

    • Property Status changed from new to assigned
    • Property Cc forsberg@… dangra@… christian@… added
    • Property Branch changed from to branches/webclient-request-cancel-4330-3
    • Property Author changed from to exarkun, habnabit
    • Property Owner changed from exarkun to itamar
  • Ticket #4330 – Description

    initial v22  
    44  1. Disconnect abort the in-progress request, if the connection has been set up and a request has been initiated. 
    55 
    6 This depends on #4329 to handle the former case. 
     6This used to depend on #4329 to handle the former case; these days it depends on endpoints supporting cancellation. 
    77