Ticket #4327 defect closed duplicate

Opened 4 years ago

Last modified 3 years ago

xmpp streams disconnects when namespaces are not well formed

Reported by: sciasbat Owned by:
Priority: normal Milestone:
Component: words Keywords:
Cc: exarkun Branch:
Author: Launchpad Bug:

Description

Though the behavior is in theory correct, due to other buggy software the xml stream disconnects when receiving tags with trailing spaces in namespaces uris. Example:

<tag xmlns="uri:sometring "/>

A trivial fix has been proposed by Ralph:

 http://www.mail-archive.com/twisted-jabber@ik.nu/msg00264.html

Change History

1

Changed 4 years ago by exarkun

  • owner changed from exarkun to ralphm
  • cc exarkun added
  • milestone regular-releases deleted

2

Changed 3 years ago by <automation>

  • owner ralphm deleted

3

Changed 3 years ago by awclin

  • owner set to awclin
  • status changed from new to assigned

4

Changed 3 years ago by awclin

  • status changed from assigned to new
  • keywords review added
  • owner awclin deleted

The fix for #4503 applies (amongst other things) the exact fix outlined in the mailing list thread referenced by the reporter. We have test_namespaceWithWhitespace in words.test.test_domish also, which seems to provide adequate cover for this issue.

Even if this ticket remains open due to the larger (potential) issue around whether we should actively drop support for namespace-well-formedness (some discussion of this is in the linked mailing list thread), I think this one can be closed, and we can open a more relevant one if needs be.

P.S. Not sure on procedure for this kind of resolution to a ticket, so putting it up for review

5

Changed 3 years ago by ralphm

  • status changed from new to closed
  • keywords review removed
  • resolution set to duplicate

Agreed. While the summary of this ticket is slightly misleading (as explained in #4503, the value may have spaces), this ticket can be closed as having been resolved by r29852 and being a (reverse) duplicate of #4503.

The discussion on real namespace-well-formedness could eventually spawn a new ticket.

Note: See TracTickets for help on using tickets.