Changing versions in NEWS files for pre-release increments is too hard

[jml]

change-versions doesn't change the version in NEWS files. build-news adds a new heading on top of the previous pre-release heading, e.g.

Twisted Core 10.0.0pre2 (2010-02-24)
====================================

Twisted Core 10.0.0pre1 (2010-02-21)
====================================

Ideally there'd be some way to bump the pre-release version. Perhaps change-versions should do this?

[jml]

(In [29225]) Branching to 'drop-pre-release-4316'

[jml]

In this branch, change-versions will alter the version and date in all NEWS files if the current release is a pre-release.

[TimAllen]

My only change would be:

--- a/twisted/python/_release.py
+++ b/twisted/python/_release.py
@@ -143,7 +143,7 @@ def changeAllProjectVersions(root, versionTemplate, today=None):
                              versionTemplate.minor, versionTemplate.micro,
                              prerelease=versionTemplate.prerelease)
 
-        if project.getVersion().prerelease:
+        if oldVersion.prerelease:
             builder = NewsBuilder()
             builder._changeNewsVersion(
                 root.child("NEWS"), builder._getNewsName(project),

...since every other call to project.getVersion() in this function has been replaced by oldVersion.

With that change, +1 for merging from me.

[jml]

Done & thanks for the review. I'm going to hold off on landing this branch until a core dev reviews it, to satisfy my own paranoia.

[jml]

(In [29242]) Merge drop-pre-release-4316

• Author: jml
• Reviewer: TimAllen
• Fixes #4316

When running change-version on a pre-release version of Twisted, change the references to the pre-release version in NEWS entries.