Opened 8 years ago

Closed 7 years ago

#4311 enhancement closed fixed (fixed)

XMPP Stanza Error 'remote-server-timeout' yield no type and code

Reported by: ralphm Owned by: ralphm
Priority: normal Milestone:
Component: words Keywords:
Cc: jesstess Branch: branches/xmpp-error-4311
branch-diff, diff-cov, branch-cov, buildbot
Author: ralphm

Description

Due to a typo in STANZA_CONDITIONS, if a StanzaError is created with the condition remote-server-timeout, the error type and code attributes are not set.

Change History (8)

comment:1 Changed 7 years ago by ralphm

Author: ralphm
Branch: branches/xmpp-error-4311

(In [28515]) Branching to 'xmpp-error-4311'

comment:2 Changed 7 years ago by ralphm

(In [28517]) Fix typo in STANZA_CONDITIONS, fix spacing and add some docstrings.

Addresses #4311.

comment:3 Changed 7 years ago by ralphm

Keywords: review added
Owner: ralphm deleted

comment:4 Changed 7 years ago by jesstess

Owner: set to jesstess

comment:5 Changed 7 years ago by jesstess

Cc: jesstess added
Keywords: review removed
Owner: jesstess deleted

Thanks for the patch, ralphm. A few comments:

  • In test_typeRemoteServerTimeout, use assertEquals (and in general the plural form of asserts)
  • If you're going to revamp test_appConditionMultiple use the plural asserts there as well.

Other than that, looks good to merge!

comment:6 Changed 7 years ago by jesstess

Owner: set to ralphm

comment:7 Changed 7 years ago by ralphm

(In [28529]) Address review comments re #4311.

comment:8 Changed 7 years ago by ralphm

Resolution: fixed
Status: newclosed

(In [28530]) Merge xmpp-error-4311: Fix typo preventing remote-server-timeout to get a stanza error type.

Author: ralphm Reviewer: jesstess Fixes: #4311

Note: See TracTickets for help on using tickets.