Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#4291 enhancement closed fixed (fixed)

NewsBuilder should add more space between sections

Reported by: therve Owned by:
Priority: normal Milestone:
Component: release management Keywords: easy
Cc: khorn Branch: branches/news-builder-lint-4291
(diff, github, buildbot, log)
Author: therve Launchpad Bug:

Description

Projects are only separated by one line, it should be two.

Attachments (3)

twisted-python-release-newlines.diff (1.5 KB) - added by djfroofy 5 years ago.
Replace projects with two newlines
twisted-python-release-omitEmptyProjects.diff (2.5 KB) - added by djfroofy 5 years ago.
Omit projects with no changes from NEWS
patch-0.diff (3.2 KB) - added by djfroofy 5 years ago.
Rebuilt patch including newline and project omission

Download all attachments as: .zip

Change History (16)

comment:1 Changed 5 years ago by therve

  • Keywords easy added

Also, it should probably not mention projects without any changes, instead of displaying an empty section.

comment:2 Changed 5 years ago by djfroofy

  • Owner changed from radix to djfroofy
  • Status changed from new to assigned

comment:3 Changed 5 years ago by djfroofy

Since this is really two isolated changes, I feel like this would be cleaner done in a branch. But I don't have commit privileges - such would be nice.

comment:4 Changed 5 years ago by djfroofy

For now, I'm attaching two patches: 1) separating projects with double newline; 2) omitting projects with no changes.

Changed 5 years ago by djfroofy

Replace projects with two newlines

Changed 5 years ago by djfroofy

Omit projects with no changes from NEWS

comment:5 Changed 5 years ago by therve

  • Keywords review added
  • Owner changed from djfroofy to therve
  • Status changed from assigned to new

comment:6 Changed 5 years ago by therve

  • Author set to therve
  • Branch set to branches/news-builder-lint-4291

(In [28376]) Branching to 'news-builder-lint-4291'

comment:7 Changed 5 years ago by therve

  • Keywords review removed
  • Owner changed from therve to djfroofy

Thanks for the patch! I think the first change is trivial enough that we can do it at the same time.

For the second patch, we shouldn't computer the NEWS data 2 times in build, but reuse them once we detected that it's not empty. Everything else looks great.

comment:8 Changed 5 years ago by djfroofy

  • Status changed from new to assigned

That's odd. I think some lines might have been rejected somehow when you applied the patch - I was computing NEWS only once and reusing in build(). I'll fix failed patch now.

Changed 5 years ago by djfroofy

Rebuilt patch including newline and project omission

comment:9 Changed 5 years ago by djfroofy

  • Keywords review added
  • Owner changed from djfroofy to therve
  • Status changed from assigned to new

comment:10 Changed 5 years ago by khorn

  • Cc khorn added

comment:11 Changed 5 years ago by therve

  • Resolution set to fixed
  • Status changed from new to closed

(In [28402]) Merge news-builder-lint-4291

Author: djfroofy
Reviewer: therve
Fixes #4291

The NEWSBuilder now adds some space between project sections, and doesn't
display a section for a project without changes.

comment:12 Changed 5 years ago by therve

  • Keywords review removed

comment:13 Changed 4 years ago by <automation>

  • Owner therve deleted
Note: See TracTickets for help on using tickets.