Ticket #4291 enhancement closed fixed

Opened 4 years ago

Last modified 4 years ago

NewsBuilder should add more space between sections

Reported by: therve Owned by:
Priority: normal Milestone:
Component: release management Keywords: easy
Cc: khorn Branch: branches/news-builder-lint-4291
(diff, github, buildbot, log)
Author: therve Launchpad Bug:

Description

Projects are only separated by one line, it should be two.

Attachments

twisted-python-release-newlines.diff Download (1.5 KB) - added by djfroofy 4 years ago.
Replace projects with two newlines
twisted-python-release-omitEmptyProjects.diff Download (2.5 KB) - added by djfroofy 4 years ago.
Omit projects with no changes from NEWS
patch-0.diff Download (3.2 KB) - added by djfroofy 4 years ago.
Rebuilt patch including newline and project omission

Change History

1

Changed 4 years ago by therve

  • keywords easy added

Also, it should probably not mention projects without any changes, instead of displaying an empty section.

2

Changed 4 years ago by djfroofy

  • owner changed from radix to djfroofy
  • status changed from new to assigned

3

Changed 4 years ago by djfroofy

Since this is really two isolated changes, I feel like this would be cleaner done in a branch. But I don't have commit privileges - such would be nice.

4

Changed 4 years ago by djfroofy

For now, I'm attaching two patches: 1) separating projects with double newline; 2) omitting projects with no changes.

Changed 4 years ago by djfroofy

Replace projects with two newlines

Changed 4 years ago by djfroofy

Omit projects with no changes from NEWS

5

Changed 4 years ago by therve

  • status changed from assigned to new
  • keywords review added
  • owner changed from djfroofy to therve

6

Changed 4 years ago by therve

  • branch set to branches/news-builder-lint-4291
  • branch_author set to therve

(In [28376]) Branching to 'news-builder-lint-4291'

7

Changed 4 years ago by therve

  • keywords review removed
  • owner changed from therve to djfroofy

Thanks for the patch! I think the first change is trivial enough that we can do it at the same time.

For the second patch, we shouldn't computer the NEWS data 2 times in build, but reuse them once we detected that it's not empty. Everything else looks great.

8

Changed 4 years ago by djfroofy

  • status changed from new to assigned

That's odd. I think some lines might have been rejected somehow when you applied the patch - I was computing NEWS only once and reusing in build(). I'll fix failed patch now.

Changed 4 years ago by djfroofy

Rebuilt patch including newline and project omission

9

Changed 4 years ago by djfroofy

  • status changed from assigned to new
  • keywords review added
  • owner changed from djfroofy to therve

10

Changed 4 years ago by khorn

  • cc khorn added

11

Changed 4 years ago by therve

  • status changed from new to closed
  • resolution set to fixed

(In [28402]) Merge news-builder-lint-4291

Author: djfroofy Reviewer: therve Fixes #4291

The NEWSBuilder now adds some space between project sections, and doesn't display a section for a project without changes.

12

Changed 4 years ago by therve

  • keywords review removed

13

Changed 3 years ago by <automation>

  • owner therve deleted
Note: See TracTickets for help on using tickets.