Opened 4 years ago

Closed 4 years ago

#4253 enhancement closed invalid (invalid)

CHANMODES parameter in ISUPPORT is parsed incorrectly

Reported by: ChosenOne Owned by:
Priority: normal Milestone: totally automated release infrastructure
Component: words Keywords: chanmodes isupport review
Cc: Branch:
Author: Launchpad Bug:

Description

The CHANMODES parameter is currently parsed incorrectly by isupport_CHANMODES.
The modeline is a comma-seperated list of letters, which gives you modes who require:

  • an address on setting and unsetting
  • a parameter on setting and unsetting
  • a parameter only on setting
  • no parameter at all.

(i.e. ('addressModes', 'param', 'setParam', 'noParam'))

Currently isupport_CHANMODES will disregard the comma and stuff all the modes into a dict which results to wrong output.

Instead, we should split the CHANMODES parameter at the comma and then build a dict according to the elements we get.

Attachments (1)

my-twisted-patch.patch (601 bytes) - added by ChosenOne 4 years ago.
patch for irc.py, which will fix the mentioned bug

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by ChosenOne

patch for irc.py, which will fix the mentioned bug

comment:1 Changed 4 years ago by ChosenOne

  • Keywords review added
  • Owner exarkun deleted

The patch will assign the parameters its correct key in the returned dict.

comment:2 Changed 4 years ago by jonathanj

  • Resolution set to invalid
  • Status changed from new to closed

This patch seems like it would introduce an AttributeError attempting to find an attribute 'split' on a list instance. The splitting this patch attempts to do is already handled by ServerSupportedFeatures.parse.

After discussing this with the original submitter, it seems that there was simply some confusion between attempting to implement CHANMODES handling themselves and their understand of Twisted's handling of it.

comment:3 Changed 3 years ago by <automation>

Note: See TracTickets for help on using tickets.