Ticket #4247 enhancement closed fixed

Opened 3 years ago

Last modified 2 years ago

Port raiser.c to 3.1

Reported by: loewis Owned by: loewis
Priority: normal Milestone: Python-3.x
Component: core Keywords: py3k
Cc: thijs Branch: branches/raiser-py3k-4247
(diff, github, buildbot, log)
Author: loewis, thijs Launchpad Bug:

Description

Porting raiser.c is fairly easy - just run raiser.pyx through a recent version of Cython. Patch attached. The test still passes in 2.5.

Attachments

raiser.diff Download (56.0 KB) - added by loewis 3 years ago.
_epoll.diff Download (135.6 KB) - added by loewis 3 years ago.
4247.misc Download (429 bytes) - added by loewis 3 years ago.

Change History

Changed 3 years ago by loewis

Changed 3 years ago by loewis

1

  Changed 3 years ago by loewis

Likewise for _epoll.

2

  Changed 3 years ago by spiv

  • keywords py3k, review added; py3k removed

3

  Changed 3 years ago by loewis

  • owner glyph deleted

Changed 3 years ago by loewis

4

follow-up: ↓ 5   Changed 3 years ago by thijs

  • cc thijs added
  • keywords py3k added; py3k, review removed
  • owner set to loewis
  • milestone set to Python-3.x

Looks like this is blocked by #4246 that wants tries to fix some other py3k stuff.. If anyone works on this ticket in the future, make sure to run it through the latest version of Cython (0.12.1 at the time of this writing) cause this patch uses an slightly outdated version of Cython.

5

in reply to: ↑ 4   Changed 3 years ago by thijs

Replying to thijs:

Looks like this is blocked by #4246 that wants tries to fix some other py3k stuff..

That should be #4244.

6

  Changed 2 years ago by thijs

  • branch set to branches/raiser-py3k-4247
  • branch_author set to thijs

(In [30892]) Branching to 'raiser-py3k-4247'

7

  Changed 2 years ago by thijs

(In [30893]) refresh pyx output files with cython 0.14.1, refs #4247

8

  Changed 2 years ago by thijs

(In [30894]) add news file, refs #4247

9

  Changed 2 years ago by thijs

  • keywords py3k, review added; py3k removed
  • owner loewis deleted
  • branch_author changed from thijs to loewis, thijs

I updated the files with Cython 0.14.1 and all tests passed here with python 2.7.1. I don't think this necessarily should be blocked by #4244 (besides adding py3k support it could potentially fix/improve other stuff) so putting it up for review.

10

  Changed 2 years ago by washort

  • keywords py3k added; py3k, review removed
  • owner set to loewis

Tests pass on debian64-py2.4-select and debian-easy-py2.5-epoll. Since this was just a rebuild of pyx files, I'm approving this.

11

  Changed 2 years ago by thijs

  • status changed from new to closed
  • resolution set to fixed

(In [31032]) Merge raiser-py3k-4247: Updated raiser.c and _epoll.c with Cython 0.14.1 to support Python 3.

Author: loewis, thijs Reviewer: washort Fixes: #4247

Note: See TracTickets for help on using tickets.