Opened 5 years ago

Closed 4 years ago

#4247 enhancement closed fixed (fixed)

Port raiser.c to 3.1

Reported by: loewis Owned by: loewis
Priority: normal Milestone: Python-3.x
Component: core Keywords: py3k
Cc: thijs Branch: branches/raiser-py3k-4247
(diff, github, buildbot, log)
Author: loewis, thijs Launchpad Bug:

Description

Porting raiser.c is fairly easy - just run raiser.pyx through a recent version of Cython. Patch attached. The test still passes in 2.5.

Attachments (3)

raiser.diff (56.0 KB) - added by loewis 5 years ago.
_epoll.diff (135.6 KB) - added by loewis 5 years ago.
4247.misc (429 bytes) - added by loewis 5 years ago.

Download all attachments as: .zip

Change History (14)

Changed 5 years ago by loewis

Changed 5 years ago by loewis

comment:1 Changed 5 years ago by loewis

Likewise for _epoll.

comment:2 Changed 5 years ago by spiv

  • Keywords review added

comment:3 Changed 5 years ago by loewis

  • Owner glyph deleted

Changed 5 years ago by loewis

comment:4 follow-up: Changed 5 years ago by thijs

  • Cc thijs added
  • Keywords review removed
  • Milestone set to Python-3.x
  • Owner set to loewis

Looks like this is blocked by #4246 that wants tries to fix some other py3k stuff.. If anyone works on this ticket in the future, make sure to run it through the latest version of Cython (0.12.1 at the time of this writing) cause this patch uses an slightly outdated version of Cython.

comment:5 in reply to: ↑ 4 Changed 5 years ago by thijs

Replying to thijs:

Looks like this is blocked by #4246 that wants tries to fix some other py3k stuff..

That should be #4244.

comment:6 Changed 4 years ago by thijs

  • Author set to thijs
  • Branch set to branches/raiser-py3k-4247

(In [30892]) Branching to 'raiser-py3k-4247'

comment:7 Changed 4 years ago by thijs

(In [30893]) refresh pyx output files with cython 0.14.1, refs #4247

comment:8 Changed 4 years ago by thijs

(In [30894]) add news file, refs #4247

comment:9 Changed 4 years ago by thijs

  • Author changed from thijs to loewis, thijs
  • Keywords review added
  • Owner loewis deleted

I updated the files with Cython 0.14.1 and all tests passed here with python 2.7.1. I don't think this necessarily should be blocked by #4244 (besides adding py3k support it could potentially fix/improve other stuff) so putting it up for review.

comment:10 Changed 4 years ago by washort

  • Keywords review removed
  • Owner set to loewis

Tests pass on debian64-py2.4-select and debian-easy-py2.5-epoll. Since this was just a rebuild of pyx files, I'm approving this.

comment:11 Changed 4 years ago by thijs

  • Resolution set to fixed
  • Status changed from new to closed

(In [31032]) Merge raiser-py3k-4247: Updated raiser.c and _epoll.c with Cython 0.14.1 to support Python 3.

Author: loewis, thijs
Reviewer: washort
Fixes: #4247

Note: See TracTickets for help on using tickets.