Changes between and of Version 26Version 27Ticket #4244


Ignore:
Timestamp:
07/15/2012 01:17:32 PM (2 years ago)
Author:
thijs
Comment:

Replying to loewis:

  • replace file with open. This will work on all 2.x versions, and 3.x doesn't have the file builtin

I've opened #5785 for this case in twisted/python/versions.py

  • parenthetise print and exec

There's one of those in setup.py that can be fixed in this ticket.

  • replace an unlink/EnvironmentError check in dist.py with a os.path.exists check. This, again, should work on all Python versions, whereas the except syntax doesn't work in 3.x.

This can also be fixed in this ticket, but there is no code coverage for build_scripts_twisted class so this will need test(s).

When you fix those points manually setup.py can be run in Python 3.2! Getting there..

$ python3.2 --version
12.1.0+r34835

$ python3.2 setup.py build
...
twisted/internet/_sigchld.c:101:1: warning: control reaches end of non-void function [-Wreturn-type]
gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro build/temp.linux-x86_64-3.2/twisted/internet/_sigchld.o -o build/lib.linux-x86_64-3.2/twisted/internet/_sigchld.cpython-32mu.so
running build_scripts
creating build/scripts-3.2
copying and adjusting bin/trial -> build/scripts-3.2
copying and adjusting bin/tap2deb -> build/scripts-3.2
copying and adjusting bin/pyhtmlizer -> build/scripts-3.2
copying and adjusting bin/tap2rpm -> build/scripts-3.2
copying and adjusting bin/manhole -> build/scripts-3.2
copying and adjusting bin/twistd -> build/scripts-3.2
copying and adjusting bin/tapconvert -> build/scripts-3.2
copying and adjusting bin/mail/mailmail -> build/scripts-3.2
copying and adjusting bin/conch/tkconch -> build/scripts-3.2
copying and adjusting bin/conch/ckeygen -> build/scripts-3.2
copying and adjusting bin/conch/conch -> build/scripts-3.2
copying and adjusting bin/conch/cftp -> build/scripts-3.2
copying and adjusting bin/lore/lore -> build/scripts-3.2
changing mode of build/scripts-3.2/trial from 664 to 775
changing mode of build/scripts-3.2/tap2deb from 664 to 775
changing mode of build/scripts-3.2/pyhtmlizer from 664 to 775
changing mode of build/scripts-3.2/tap2rpm from 664 to 775
changing mode of build/scripts-3.2/manhole from 664 to 775
changing mode of build/scripts-3.2/twistd from 664 to 775
changing mode of build/scripts-3.2/tapconvert from 664 to 775
changing mode of build/scripts-3.2/mailmail from 664 to 775
changing mode of build/scripts-3.2/tkconch from 664 to 775
changing mode of build/scripts-3.2/ckeygen from 664 to 775
changing mode of build/scripts-3.2/conch from 664 to 775
changing mode of build/scripts-3.2/cftp from 664 to 775
changing mode of build/scripts-3.2/lore from 664 to 775

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4244

    • Property Summary changed from Allow running setup.py in Python 3.1 to Allow running setup.py in Python 3
  • Ticket #4244 – Description

    v26 v27  
    88 
    99The 3.x changes can be summarized as follows: 
    10   - replace file with open. This will work on all 2.x versions, and 3.x doesn't have the  
     10  - replace file with open (#5785). This will work on all 2.x versions, and 3.x doesn't have the  
    1111    file builtin 
    1212  - provide an implementation for execfile in 3.x. 2to3 will also fix all execfile usage,