conch\telnet.py does not allow for Binary Transmission or End of Record

[kench]

The state machine as implemented in the Telnet.dataReceived method will have problems when the options for Binary Transmission (RFC856) or End of Record (RFC885) have been negotiated, whether explicitly or implicitly as part of some other negotiated option, such as TN3270E (RFC2355).

(1) When the telnet session is in binary mode the state machine should not be transitioning into 'newline' state when a byte value of '\r' is encountered.

(2) It needs to allow for receiving an IAC EOR command delimiting a data record.

[kench]

Suggestion for (1): Define a new attribute, self.binaryMode = False, that can then be overridden to True when an option requiring binary mode is negotiated. Then use that attribute in Telnet.dataReceived to guard the transition to 'newline' state:

            if self.state == 'data':
                if b == IAC:
                ...
-                elif b == '\r':
+                elif b == '\r' and not self.binaryMode:
                    self.state = 'newline'

Suggestion for (2): Define a new command constant for EOR and add another elif clause to the 'escaped' state:

+EOR =            chr(239) # End of record.
            ...
            elif self.state == 'escaped':
                if b == IAC:
                ...
+                elif b == EOR:
+                    self.state = 'data'
+                    appDataBuffer.extend([IAC, EOR])
                else:

[exarkun]

Should IAC EOR really be delivered as application bytes? I have perhaps imagined something more like the commandReceived case for this.

[kench]

Replying to exarkun:

Should IAC EOR really be delivered as application bytes? I have perhaps imagined something more like the commandReceived case for this.

Despite being implemented as an IAC command, IAC EOR is a delimiter -- more like a CR/LF than a "command".