Ticket #4191 defect closed fixed

Opened 4 years ago

Last modified 4 years ago

bin/admin/build-news generates empty sections when a project has had no changes.

Reported by: radix Owned by:
Priority: normal Milestone:
Component: release management Keywords:
Cc: Branch: branches/no-news-4191
(diff, github, buildbot, log)
Author: jml Launchpad Bug:

Description

We should probably write something like "No significant changes have been made for this release." in this case.

Change History

1

Changed 4 years ago by jml

  • owner changed from radix to jml
  • status changed from new to assigned

2

Changed 4 years ago by jml

  • branch set to branches/no-news-4191
  • branch_author set to jml

(In [29216]) Branching to 'no-news-4191'

3

Changed 4 years ago by jml

This bug was fixed along with bug #4291 as part of [28402]. However, the fix there simply does not generate a news section for projects that have had no changes. A section that says "No significant changes made for this release" would actually be more helpful and less confusing to users, I think.

4

Changed 4 years ago by exarkun

A section that says "No significant changes made for this release" would actually be more helpful and less confusing to users, I think.

+1

5

Changed 4 years ago by jml

If there are only "misc" changes in the project's topfiles section, the NEWS entry looks like:

Twisted News 10.0.0 (2010-06-06)
================================

Other
-----
 - #7777

This should include text like "No significant changes have been made for this release" before listing the miscellaneous changes.

6

Changed 4 years ago by jml

(In [29217]) If there were no changes, say so. refs #4191

7

Changed 4 years ago by jml

  • status changed from assigned to new
  • owner jml deleted
  • keywords review added

I've changed the test that said "omit the section if there are no changes". I think the branch is ready for review.

8

Changed 4 years ago by therve

  • keywords review removed
  • owner set to jml

+1!

9

Changed 4 years ago by jml

  • status changed from new to closed
  • resolution set to fixed

(In [29221]) Merge no-news-4191.

  • Author: jml
  • Reviewer: therve
  • Fixes #4191

When generating NEWS sections for projects with no changes, include a message saying that the project has had no changes.

10

Changed 3 years ago by <automation>

  • owner jml deleted
Note: See TracTickets for help on using tickets.