Opened 5 years ago

Closed 5 years ago

#4191 defect closed fixed (fixed)

bin/admin/build-news generates empty sections when a project has had no changes.

Reported by: radix Owned by:
Priority: normal Milestone:
Component: release management Keywords:
Cc: Branch: branches/no-news-4191
(diff, github, buildbot, log)
Author: jml Launchpad Bug:

Description

We should probably write something like "No significant changes have been made for this release." in this case.

Change History (10)

comment:1 Changed 5 years ago by jml

  • Owner changed from radix to jml
  • Status changed from new to assigned

comment:2 Changed 5 years ago by jml

  • Author set to jml
  • Branch set to branches/no-news-4191

(In [29216]) Branching to 'no-news-4191'

comment:3 Changed 5 years ago by jml

This bug was fixed along with bug #4291 as part of [28402]. However, the fix there simply does not generate a news section for projects that have had no changes. A section that says "No significant changes made for this release" would actually be more helpful and less confusing to users, I think.

comment:4 Changed 5 years ago by exarkun

A section that says "No significant changes made for this release" would actually be more helpful and less confusing to users, I think.

+1

comment:5 Changed 5 years ago by jml

If there are only "misc" changes in the project's topfiles section, the NEWS entry looks like:

Twisted News 10.0.0 (2010-06-06)
================================

Other
-----
 - #7777

This should include text like "No significant changes have been made for this release" before listing the miscellaneous changes.

comment:6 Changed 5 years ago by jml

(In [29217]) If there were no changes, say so. refs #4191

comment:7 Changed 5 years ago by jml

  • Keywords review added
  • Owner jml deleted
  • Status changed from assigned to new

I've changed the test that said "omit the section if there are no changes". I think the branch is ready for review.

comment:8 Changed 5 years ago by therve

  • Keywords review removed
  • Owner set to jml

+1!

comment:9 Changed 5 years ago by jml

  • Resolution set to fixed
  • Status changed from new to closed

(In [29221]) Merge no-news-4191.

  • Author: jml
  • Reviewer: therve
  • Fixes #4191

When generating NEWS sections for projects with no changes, include a
message saying that the project has had no changes.

comment:10 Changed 4 years ago by <automation>

  • Owner jml deleted
Note: See TracTickets for help on using tickets.