Opened 5 years ago

Closed 4 years ago

#4190 defect closed fixed (fixed)

bin/admin/build-news builds news for web2 even though web2 no longer has releases

Reported by: radix Owned by:
Priority: normal Milestone:
Component: release management Keywords:
Cc: Branch: branches/news-blacklist-4190
(diff, github, buildbot, log)
Author: jml Launchpad Bug:

Description

It shouldn't generate web2 news.

Change History (6)

comment:1 Changed 4 years ago by jml

  • Author set to jml
  • Branch set to branches/news-blacklist-4190

(In [29219]) Branching to 'news-blacklist-4190'

comment:2 Changed 4 years ago by jml

(In [29222]) Do not generate news for blacklisted projects. refs #4190.

comment:3 Changed 4 years ago by jml

  • Keywords review added
  • Owner radix deleted

In this branch, I moved out the literal value of DistributionBuilder.blacklist to a new top-level variable PROJECT_BLACKLIST and made DistributionBuilder.blacklist equal to that.

NewsBuilder gets a similar class variable, blacklist. It's only consulted in buildAll.

For testing, I just added a blacklisted project to the existing test for buildAll, since I couldn't see any value in adding a new test and since I couldn't think of a more unit-y test.

If this branch lands, the current branch for #4138 will need to be updated. I had thought of adding a blacklisted property to project, but that would make #4138 even more difficult to land.

comment:4 Changed 4 years ago by therve

  • Keywords review removed
  • Owner set to jml

Looks great, please merge.

comment:5 Changed 4 years ago by jml

  • Resolution set to fixed
  • Status changed from new to closed

(In [29224]) Merge news-blacklist-4190

  • Author: jml
  • Reviewer: therve
  • Fixes #4190

Do not generate news sections for blacklisted projects.

comment:6 Changed 3 years ago by <automation>

  • Owner jml deleted
Note: See TracTickets for help on using tickets.