Function singleSearchStep was renamed to _singleSearchStep not everywhere

[natta]

Function singleSearchStep was renamed to _singleSearchStep and one parameter added, but in search_OR and search_NOT fucntions there is still old version function invocation (i.e. without "_") So every search query that contains OR or NOT keywords raises errors.

[natta]

Patch that replaces singleSearchStep with _singleSearchStep in search_(NOT|OR)

[natta]

I can not commit changes, so i reassign it back

[exarkun]

Regression introduced by #1977.

[exarkun]

Thanks for the patch, natta. Can you supply one which also includes unit tests for this fix? twisted.mail.test.test_imap.DefaultSearchTestCase may be a good case to extend.

[natta]

Replying to exarkun:

Thanks for the patch, natta. Can you supply one which also includes unit tests for this fix? twisted.mail.test.test_imap.DefaultSearchTestCase may be a good case to extend.

OK. As so I am not a very experienced developer, but I'll try.

[exarkun]

(In [28242]) Branching to 'imap-search-fixes-4178'

[exarkun]

Fixed and tested, please review.

[therve]

So I would prefer another way to check if the lastSequenceId parameter is required. Something like that:

_requiresLastSequenceId = set(["NOT", "OR"])

if c in self._requiresLastSequenceId:
     result = f(query, id, msg, lastSequenceId)
else:
     result = f(query, id, msg)

The tests need to fit in 80 colums, too.

Please merge after that.

[exarkun]

(In [28281]) Merge imap-search-fixes-4178

Author: exarkun, itamar Reviewer: therve Fixes: #4178

Fix the regression in search OR and NOT support in the IMAP4 server's fallback search support.