Opened 7 years ago

Closed 7 years ago

#4170 defect closed fixed (fixed)

Remove statements about recent split

Reported by: Thijs Triemstra Owned by: Thijs Triemstra
Priority: normal Milestone: Twisted-10.0
Component: core Keywords: documentation
Cc: Thijs Triemstra, jesstess Branch:
Author:

Description

The following files state that there was a recent split, but it looks like this happened (4) years ago:

  • [source:trunk/twisted/mail/topfiles/README]
  • [source:trunk/twisted/pair/topfiles/README]

Attachments (2)

split-topfiles.patch (776 bytes) - added by Thijs Triemstra 7 years ago.
split-topfiles.2.patch (636 bytes) - added by Thijs Triemstra 7 years ago.
patch with newlines

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Thijs Triemstra

Attachment: split-topfiles.patch added

comment:1 Changed 7 years ago by Thijs Triemstra

Keywords: documentation review added
Owner: Thijs Triemstra deleted

comment:2 Changed 7 years ago by jesstess

Cc: jesstess added
Keywords: review removed
Owner: set to Thijs Triemstra

There aren't newlines on either of the files anymore if you apply the patch - not sure if that's desirable. Other than that, apply away.

Changed 7 years ago by Thijs Triemstra

Attachment: split-topfiles.2.patch added

patch with newlines

comment:3 in reply to:  2 Changed 7 years ago by Thijs Triemstra

Status: newassigned

Replying to jesstess:

There aren't newlines on either of the files anymore if you apply the patch - not sure if that's desirable. Other than that, apply away.

Thanks for the review. I attached a new patch with newlines that I'll apply now.

comment:4 Changed 7 years ago by Thijs Triemstra

Resolution: fixed
Status: assignedclosed

(In [27816]) Apply split-topfiles.2.patch: remove statements about recent Twisted split.

Author: thijs Reviewer: jesstess Fixes: #4170

Note: See TracTickets for help on using tickets.