Opened 7 years ago

Closed 7 years ago

#4154 task closed fixed (fixed)

Skip all release automation related tests on platforms which are not Linux

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: release management Keywords: tests
Cc: radix, Thijs Triemstra Branch: branches/skip-release-tests-4154
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

Since the release is done on Linux, and these release tools are explicitly for our use only, it's a bit of a waste to run the tests for them on other platforms, and an even bigger waste to spend development effort making the code portable and so on.

So, let's skip the tests everywhere but on Linux.

Change History (8)

comment:1 Changed 7 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/skip-release-tests-4154

(In [27687]) Branching to 'skip-release-tests-4154'

comment:2 Changed 7 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

comment:3 Changed 7 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review removed
Owner: set to Jean-Paul Calderone

I'm assuming they should be skipped on OSX as well?

I guess the following tests are not part of the release process? Seems to me they can be skipped though, but I could be wrong.

twisted.python.test.test_dist
  GetScriptsTest
    test_getScriptsTopLevel ...                                            [OK]
    test_noScriptsInSVN ...                                                [OK]
    test_noScriptsInSubproject ...                                         [OK]
    test_scriptsInRelease ...                                              [OK]
    test_scriptsInSVN ...                                                  [OK]
  GetVersionTest
    test_getVersionCore ...                                                [OK]
    test_getVersionOther ...                                               [OK]
  SetupTest
    test_conditionalExtensions ...                                         [OK]
    test_win32Definition ...                                               [OK]

And why are the BuildAllTarballsTest and DistributionBuilderTest tests not being skipped?

twisted.python.test.test_release
  APIBuilderTestCase
    test_apiBuilderScriptMain ...                                     [SKIPPED]
    test_apiBuilderScriptMainRequiresTwoArguments ...                 [SKIPPED]
    test_build ...                                                    [SKIPPED]
    test_buildWithPolicy ...                                          [SKIPPED]
  BookBuilderTests
    test_build ...                                                    [SKIPPED]
    test_buildPDF ...                                                 [SKIPPED]
    test_buildPDFLongPath ...                                         [SKIPPED]
    test_buildPDFRejectsInvalidBookFilename ...                       [SKIPPED]
    test_buildPDFRunsLaTeXThreeTimes ...                              [SKIPPED]
    test_buildRemovesTemporaryLaTeXFiles ...                          [SKIPPED]
    test_buildTeX ...                                                 [SKIPPED]
    test_buildTeXOnlyBuildsXHTML ...                                  [SKIPPED]
    test_buildTeXRejectsInvalidDirectory ...                          [SKIPPED]
    test_failedCommandProvidesOutput ...                              [SKIPPED]
    test_noSideEffects ...                                            [SKIPPED]
    test_runFailed ...                                                [SKIPPED]
    test_runSignaled ...                                              [SKIPPED]
    test_runSuccess ...                                               [SKIPPED]
    test_stdout ...                                                   [SKIPPED]
  BuildAllTarballsTest
    test_buildAllTarballs ...                                              [OK]
    test_buildAllTarballsEnsuresCleanCheckout ...                          [OK]
    test_buildAllTarballsEnsuresExistingCheckout ...                       [OK]
  ChangeVersionTest
    test_changeAllProjectVersions ...                                 [SKIPPED]
    test_changeVersionInFile ...                                      [SKIPPED]
    test_getNextVersion ...                                           [SKIPPED]
    test_getNextVersionAfterYearChange ...                            [SKIPPED]
  DistributionBuilderTest
    test_apiBaseURL ...                                                    [OK]
    test_coreProjectLayout ...                                             [OK]
    test_minimalSubProjectLayout ...                                       [OK]
    test_subProjectDocBuilding ...                                         [OK]
    test_subProjectLayout ...                                              [OK]
    test_twistedDistribution ...                                           [OK]
    test_twistedDistributionExcludesWeb2AndVFSAndAdmin ...                 [OK]
  DocBuilderTestCase
    test_apiLinking ...                                                    [OK]
    test_build ...                                                         [OK]
    test_deleteInput ...                                                   [OK]
    test_doNotDeleteInput ...                                              [OK]
    test_getLinkrelToParentDirectory ...                                   [OK]
    test_getLinkrelToSameDirectory ...                                     [OK]
    test_getLinkrelToSibling ...                                           [OK]
    test_getLinkrelToUncle ...                                             [OK]
    test_noDocumentsFound ...                                              [OK]
    test_parentDocumentLinking ...                                         [OK]
    test_siblingDirectoryDocumentLinking ...                               [OK]
  FilePathDeltaTest
    test_filePathDeltaSiblingDir ...                                  [SKIPPED]
    test_filePathDeltaSubdir ...                                      [SKIPPED]
    test_filePathNoCommonElements ...                                 [SKIPPED]
  ManBuilderTestCase
    test_build ...                                                         [OK]
    test_noDocumentsFound ...                                              [OK]
    test_toHTML ...                                                        [OK]
  NewsBuilderTests
    test_build ...                                                    [SKIPPED]
    test_buildAll ...                                                 [SKIPPED]
    test_duplicatesMerged ...                                         [SKIPPED]
    test_emptySectionsOmitted ...                                     [SKIPPED]
    test_findBugfixes ...                                             [SKIPPED]
    test_findFeatures ...                                             [SKIPPED]
    test_findMiscellaneous ...                                        [SKIPPED]
    test_findRemovals ...                                             [SKIPPED]
    test_preserveTicketHint ...                                       [SKIPPED]
    test_today ...                                                    [SKIPPED]
    test_writeHeader ...                                              [SKIPPED]
    test_writeMisc ...                                                [SKIPPED]
    test_writeSection ...                                             [SKIPPED]
  ProjectTest
    test_findTwistedStyleProjects ...                                 [SKIPPED]
    test_getVersion ...                                               [SKIPPED]
    test_repr ...                                                     [SKIPPED]
    test_updateTwistedVersionInformation ...                          [SKIPPED]
    test_updateVersion ...                                            [SKIPPED]
  ScriptTests
    test_badNumberOfArgumentsToBuildNews ...                          [SKIPPED]
    test_badNumberOfArgumentsToBuildTarballs ...                      [SKIPPED]
    test_badNumberOfArgumentsToChangeVersionsScript ...               [SKIPPED]
    test_buildNews ...                                                [SKIPPED]
    test_buildTarballsScript ...                                      [SKIPPED]
    test_changeVersions ...                                           [SKIPPED]
    test_changeVersionsWithPrerelease ...                             [SKIPPED]
    test_defaultBuildTarballsScriptBuilder ...                        [SKIPPED]
    test_defaultChangeVersionsVersionChanger ...                      [SKIPPED]
    test_nonIntPartsToChangeVersionsScript ...                        [SKIPPED]
    test_tooManyDotsToChangeVersionsScript ...                        [SKIPPED]
  UtilityTest
    test_chdir ...                                                    [SKIPPED]
    test_replaceInFile ...                                            [SKIPPED]
  VersionWritingTest
    test_replaceProjectVersion ...                                    [SKIPPED]
    test_replaceProjectVersionWithPrerelease ...                      [SKIPPED]

Tested on OSX 10.5.8 with Python 2.6.4.

Perhaps the docstring of the module should have a note explaining why the tests are (not) being skipped (on linux)?

comment:4 Changed 7 years ago by Jean-Paul Calderone

(In [27788]) Update module docstrings; fix the skip logic to make sure it really skips on bad platforms

refs #4154

comment:5 Changed 7 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

Thanks for the review.

I fixed the skips. It seems that having skip set to None on a test case overrides having a non-None skip at the module level.

twisted.python.dist is used by setup.py so it does need to continue to work on all supported platforms.

I also updated the module docstrings to talk about the Linux-only restriction.

comment:6 Changed 7 years ago by therve

Keywords: review removed
Owner: set to Jean-Paul Calderone

Cool, +1.

comment:7 Changed 7 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [27823]) Merge skip-release-tests-4154

Author: exarkun Reviewer: thijs, therve Fixes: #4154

Skip all of the automated release process unit tests on all platforms except Linux (the only platform where the automated release process needs to work).

comment:8 Changed 6 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.