Opened 8 years ago

Closed 6 years ago

#4148 task closed duplicate (duplicate)

Remove deprecated stuff in twisted/internet/address.py

Reported by: Thijs Triemstra Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Thijs Triemstra, Ying Li Branch: branches/cleanup-address-4148
branch-diff, diff-cov, branch-cov, buildbot
Author: thijs

Description

__getitem__ and __getslice__ in [source:trunk/twisted/internet/address.py] are deprecated for 3+ years at the time of this writing, so let's remove it.

Attachments (1)

address-4148.patch (3.4 KB) - added by Thijs Triemstra 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by Thijs Triemstra

Attachment: address-4148.patch added

comment:1 Changed 8 years ago by Thijs Triemstra

Keywords: review added
Owner: Glyph deleted

comment:2 Changed 8 years ago by khorn

Keywords: review removed
Owner: set to Thijs Triemstra

Looks good. Merge it!

comment:3 Changed 8 years ago by Jean-Paul Calderone

I think you missed some deprecated stuff. Also, news file.

comment:4 Changed 8 years ago by Thijs Triemstra

Status: newassigned

comment:5 Changed 7 years ago by Thijs Triemstra

Cc: Ying Li added

comment:6 Changed 7 years ago by Thijs Triemstra

Author: thijs
Branch: branches/cleanup-address-4148

(In [30554]) Branching to 'cleanup-address-4148'

comment:7 Changed 7 years ago by <automation>

Owner: Thijs Triemstra deleted

comment:8 Changed 6 years ago by Thijs Triemstra

Resolution: duplicate
Status: assignedclosed

This was done in #4817 (r30743), marking this as a duplicate.

Note: See TracTickets for help on using tickets.