Opened 7 years ago

Last modified 6 years ago

#4145 task new

Remove deprecated t.i.iocpreactor.udp.Port.loseConnection

Reported by: thijs Owned by:
Priority: normal Milestone:
Component: core Keywords: question
Cc: thijs, exarkun Branch:


Port.loseConnection in [source:trunk/twisted/internet/iocpreactor/] is deprecated, let's remove it.

Change History (5)

comment:1 Changed 7 years ago by glyph

  • Owner changed from glyph to PenguinOfDoom

comment:2 Changed 7 years ago by cyli

  • Owner changed from PenguinOfDoom to thijs

twisted.internet.iocpreactor.udp.Port inherits from twisted.internet.iocpreactor.abstract.FileHandle, and if loseConnection is removed, abstract.FileHandle.loseConnection will be called (and that is not a method that simply raises a NotImplementedError).

Also, twisted.internet.iocpreactor.tcp.Port.loseConnection is not deprecated. Neither is twisted.internet.iocpreactor.abstract.FileHandle.loseConnection.

t.i.iocpreactor.tcp.Port.stopListening is implemented, but it is not documented (udp.Port.stopListening is also undocumented).

I think perhaps this task should be changed so that all of the loseConnection methods in udp.Port, tcp.Port, and abstract.FileHandle should be deprecated at the same time, and perhaps stopListening documented (and/or implemented) on all 3.

Alternatively, perhaps udp.Port.loseConnection should raise NotImplementedError instead of being removed?

comment:3 Changed 7 years ago by cyli

  • Keywords question added

comment:4 Changed 6 years ago by thijs

  • Cc exarkun added

comment:5 Changed 6 years ago by <automation>

  • Owner thijs deleted
Note: See TracTickets for help on using tickets.