Opened 8 years ago

Last modified 7 years ago

#4145 task new

Remove deprecated t.i.iocpreactor.udp.Port.loseConnection

Reported by: Thijs Triemstra Owned by:
Priority: normal Milestone:
Component: core Keywords: question
Cc: Thijs Triemstra, Jean-Paul Calderone Branch:
Author:

Description

Port.loseConnection in [source:trunk/twisted/internet/iocpreactor/udp.py] is deprecated, let's remove it.

Change History (5)

comment:1 Changed 7 years ago by Glyph

Owner: changed from Glyph to PenguinOfDoom

comment:2 Changed 7 years ago by Ying Li

Owner: changed from PenguinOfDoom to Thijs Triemstra

twisted.internet.iocpreactor.udp.Port inherits from twisted.internet.iocpreactor.abstract.FileHandle, and if loseConnection is removed, abstract.FileHandle.loseConnection will be called (and that is not a method that simply raises a NotImplementedError).

Also, twisted.internet.iocpreactor.tcp.Port.loseConnection is not deprecated. Neither is twisted.internet.iocpreactor.abstract.FileHandle.loseConnection.

t.i.iocpreactor.tcp.Port.stopListening is implemented, but it is not documented (udp.Port.stopListening is also undocumented).

I think perhaps this task should be changed so that all of the loseConnection methods in udp.Port, tcp.Port, and abstract.FileHandle should be deprecated at the same time, and perhaps stopListening documented (and/or implemented) on all 3.

Alternatively, perhaps udp.Port.loseConnection should raise NotImplementedError instead of being removed?

comment:3 Changed 7 years ago by Ying Li

Keywords: question added

comment:4 Changed 7 years ago by Thijs Triemstra

Cc: Jean-Paul Calderone added

comment:5 Changed 6 years ago by <automation>

Owner: Thijs Triemstra deleted
Note: See TracTickets for help on using tickets.