Opened 5 years ago

Closed 4 years ago

#4107 task closed fixed (fixed)

Remove deprecated twisted.cred.util

Reported by: thijs Owned by:
Priority: highest Milestone:
Component: core Keywords: easy
Cc: thijs Branch: branches/remove-cred-util-4107
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

The docstring of trunk/twisted/cred/util.py mentions:

Outdated, deprecated functionality related to challenge-based authentication.

Seek a solution to your problem elsewhere.  This module is deprecated.

Let's get rid of it asap.

Attachments (1)

4107.diff (4.1 KB) - added by cyli 4 years ago.
Removed twisted.cred.util and its corresponding deprecation test in tests/test_newcred.py

Download all attachments as: .zip

Change History (11)

comment:1 Changed 4 years ago by glyph

  • Owner changed from glyph to thijs

Changed 4 years ago by cyli

Removed twisted.cred.util and its corresponding deprecation test in tests/test_newcred.py

comment:2 Changed 4 years ago by cyli

  • Keywords review added
  • Owner thijs deleted

comment:3 Changed 4 years ago by cyli

  • Keywords easy added

comment:4 Changed 4 years ago by mithrandi

  • Keywords review removed
  • Owner set to cyli

Looks good, please merge.

comment:5 Changed 4 years ago by cyli

  • Resolution set to fixed
  • Status changed from new to closed

(In [29095]) Apply patch 4107.diff from ticket 4107: remove twisted.cred.util

Author: cyli
Reviewer: mithrandi
Fixes: #4107

Removed twisted.cred.util and its corresponding deprecation test in tests/test_newcred.py.

comment:6 Changed 4 years ago by exarkun

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopened in r30023

comment:7 Changed 4 years ago by exarkun

(In [30023]) Revert r29095 - incorrectly applied patch

Reopens #4107

The file to be removed, twisted/cred/util.py, was not actually removed.

comment:8 Changed 4 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/remove-cred-util-4107

(In [30024]) Branching to 'remove-cred-util-4107'

comment:9 Changed 4 years ago by exarkun

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [30026]) Merge remove-cred-util-4107

Author: cyli
Reviewer: mithrandi
Fixes: #4107

Remove twisted.cred.util and its corresponding deprecation tests. This
re-merge corrects the fact that previously only the contents of
twisted/cred/util.py were removed, not the file itself.

comment:10 Changed 3 years ago by <automation>

  • Owner cyli deleted
Note: See TracTickets for help on using tickets.