Opened 7 years ago

Closed 7 years ago

#4107 task closed fixed (fixed)

Remove deprecated twisted.cred.util

Reported by: Thijs Triemstra Owned by:
Priority: highest Milestone:
Component: core Keywords: easy
Cc: Thijs Triemstra Branch: branches/remove-cred-util-4107
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

The docstring of [source:trunk/twisted/cred/util.py] mentions:

Outdated, deprecated functionality related to challenge-based authentication.

Seek a solution to your problem elsewhere.  This module is deprecated.

Let's get rid of it asap.

Attachments (1)

4107.diff (4.1 KB) - added by Ying Li 7 years ago.
Removed twisted.cred.util and its corresponding deprecation test in tests/test_newcred.py

Download all attachments as: .zip

Change History (11)

comment:1 Changed 7 years ago by Glyph

Owner: changed from Glyph to Thijs Triemstra

Changed 7 years ago by Ying Li

Attachment: 4107.diff added

Removed twisted.cred.util and its corresponding deprecation test in tests/test_newcred.py

comment:2 Changed 7 years ago by Ying Li

Keywords: review added
Owner: Thijs Triemstra deleted

comment:3 Changed 7 years ago by Ying Li

Keywords: easy added

comment:4 Changed 7 years ago by Tristan Seligmann

Keywords: review removed
Owner: set to Ying Li

Looks good, please merge.

comment:5 Changed 7 years ago by Ying Li

Resolution: fixed
Status: newclosed

(In [29095]) Apply patch 4107.diff from ticket 4107: remove twisted.cred.util

Author: cyli Reviewer: mithrandi Fixes: #4107

Removed twisted.cred.util and its corresponding deprecation test in tests/test_newcred.py.

comment:6 Changed 7 years ago by Jean-Paul Calderone

Resolution: fixed
Status: closedreopened

Reopened in r30023

comment:7 Changed 7 years ago by Jean-Paul Calderone

(In [30023]) Revert r29095 - incorrectly applied patch

Reopens #4107

The file to be removed, twisted/cred/util.py, was not actually removed.

comment:8 Changed 7 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/remove-cred-util-4107

(In [30024]) Branching to 'remove-cred-util-4107'

comment:9 Changed 7 years ago by Jean-Paul Calderone

Resolution: fixed
Status: reopenedclosed

(In [30026]) Merge remove-cred-util-4107

Author: cyli Reviewer: mithrandi Fixes: #4107

Remove twisted.cred.util and its corresponding deprecation tests. This re-merge corrects the fact that previously only the contents of twisted/cred/util.py were removed, not the file itself.

comment:10 Changed 6 years ago by <automation>

Owner: Ying Li deleted
Note: See TracTickets for help on using tickets.